Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync main branch with Apache main branch #4

Merged
merged 21 commits into from
Jan 30, 2024

Conversation

rgdoliveira
Copy link
Member

Description of the change:

Motivation for the change:

Checklist

  • Add or Modify a unit test for your change
  • Have you verified that tall the tests are passing?
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

ricardozanini and others added 21 commits January 29, 2024 12:28
… manifests in workflowproj (apache#320)

Signed-off-by: Ricardo Zanini <[email protected]>
* [KOGITO-9940] Added job service field in platform CRD

Signed-off-by: Jordi Gil <[email protected]>

* Add reconciliation logic for Job Service

Signed-off-by: Jordi Gil <[email protected]>

* Added ServiceType enum type and changed the image tag based on operator version

Signed-off-by: Jordi Gil <[email protected]>

* Make generate-all

* Add application.properties entry for jobService URL Property

Signed-off-by: Jordi Gil <[email protected]>

* Renaming serviceSpec field 'job' to 'jobService'

Signed-off-by: Jordi Gil <[email protected]>

* Add missing job service properties

Signed-off-by: Jordi Gil <[email protected]>

* Add reactive property when postgreSQL is configured as persistence for jobs-service

Signed-off-by: Jordi Gil <[email protected]>

* Refactor to use interface

Signed-off-by: Jordi Gil <[email protected]>

* Refactoring services to extract from profiles/common

Signed-off-by: Jordi Gil <[email protected]>

* Moved platform services and reconciliation constants to common/constants and avoid duplications between packages

Signed-off-by: Jordi Gil <[email protected]>

* Updated golang doc function description for GenerateJobServiceApplicationProperties and GenerateDataIndexApplicationProperties

Signed-off-by: Jordi Gil <[email protected]>

* Updated ginkgo to v2.13.0 and gomega to v1.30.0

Signed-off-by: Jordi Gil <[email protected]>

* Added unit tests for data index and job service application properties

* Changes based on feedback from Walter

Signed-off-by: Jordi Gil <[email protected]>

* Revert "Changes based on feedback from Walter"

This reverts commit 2b3638a.

* Check for not dev profile instead of production one for condition to generate the application service properties.
Reactive URL for job service won't include a default schema if it's not provided in the JDBC URL for PostgreSQL
Hardcoded Job Service replica count to 1.

Signed-off-by: Jordi Gil <[email protected]>

* Include the platform service application properties in each service's configmap

Signed-off-by: Jordi Gil <[email protected]>

* Fix sonataflowplatform_controller_test.go failing due to invalid postgresql port value

Signed-off-by: Jordi Gil <[email protected]>

* Fix tests due to changes in schema and additional properties for the job service

Signed-off-by: Jordi Gil <[email protected]>

* Extended logic in Job Service for application property generation to cover the two cases of deploying the service with its unique properties and the ones generated specific for workflow deployments

Signed-off-by: Jordi Gil <[email protected]>

* Updated generated properties based on feedback

Signed-off-by: Jordi Gil <[email protected]>

* Refactored unit tests for properties and rebased to fix e2e test

Signed-off-by: Jordi Gil <[email protected]>

* Add JS generated property for deployment  and cleaning chores on property tests

Signed-off-by: Jordi Gil <[email protected]>

---------

Signed-off-by: Jordi Gil <[email protected]>
* Fix apache#333 - 🔒 Bump crypto to 0.17.0

Signed-off-by: Ricardo Zanini <[email protected]>

* Rebase with changes on JobsService PR

Signed-off-by: Ricardo Zanini <[email protected]>

---------

Signed-off-by: Ricardo Zanini <[email protected]>
…start a build (apache#318)

* [KOGITO-8792] - Add events to build controllers and the ability to restart a build

Signed-off-by: Ricardo Zanini <[email protected]>

* Add the ability to restart builds and signal to workflows

Signed-off-by: Ricardo Zanini <[email protected]>

* Rollout deployment after a successful build

Signed-off-by: Ricardo Zanini <[email protected]>

* Fix rollout deployment once a build finishes

Signed-off-by: Ricardo Zanini <[email protected]>

---------

Signed-off-by: Ricardo Zanini <[email protected]>
* Increase E2E test timeouts

* Increase E2E test timeout
…n changes (apache#325)

* use annotations to restart deployment in prod profile, when cm changes

* adding domain to checksum annotation

* fixed missing / in checksum annotation

* annotations can have only one '/': replaced the second with a dash '-'

* Updated to use newDeploymentReconciler

* Fixed test code while wiating for SRVLOGIC-195
… logs (apache#354)

* [KOGITO-10013] Migrate from Minikube to Kind for E2E tests

Signed-off-by: Jordi Gil <[email protected]>

* Add headers and set log retention to minimum (1 day)

Signed-off-by: Jordi Gil <[email protected]>

* Changed registry port reference to 5001 and reference to Minikube to Kind

Signed-off-by: Jordi Gil <[email protected]>

* Add makefile targets to install kind, create and delete cluster and amend github action to use the create cluster target

Signed-off-by: Jordi Gil <[email protected]>

* Load controller built image to node with kind load docker-image

Signed-off-by: Jordi Gil <[email protected]>

* Remove podman from build process in e2e lane

Signed-off-by: Jordi Gil <[email protected]>

* Install python's docker libraries: docker and python-docker

Signed-off-by: Jordi Gil <[email protected]>

* Add docker-squash as pip egg to build the image

Signed-off-by: Jordi Gil <[email protected]>

---------

Signed-off-by: Jordi Gil <[email protected]>
… API Phase4 (apache#338)

* kie-kogito-serverless-operator-335: Operator driven service discovery API Phase4
    - Add the discovery of Openshift DeploymentConfigs and Routes to the service discovery API

* kie-kogito-serverless-operator-335: Operator driven service discovery API Phase4
    - Code review suggestions 1

* kie-kogito-serverless-operator-335: Operator driven service discovery API Phase4
    - Code review suggestions 2

* kie-kogito-serverless-operator-335: Operator driven service discovery API Phase4
    - Augment the service uri query parameters
* [KIE-830] Make SonataFlow Operator build reproducible

Signed-off-by: Ricardo Zanini <[email protected]>

* Add minor version to image.yaml

Signed-off-by: Ricardo Zanini <[email protected]>

* Force git date to the build files

Signed-off-by: Ricardo Zanini <[email protected]>

* Formatting issues

Signed-off-by: Ricardo Zanini <[email protected]>

* Use ubi9, add kind_version to e2e, fix ts on manager file

Signed-off-by: Ricardo Zanini <[email protected]>

* Fixing env var typo

Signed-off-by: Ricardo Zanini <[email protected]>

---------

Signed-off-by: Ricardo Zanini <[email protected]>
…vice and Data Index in a combination of scenarios with ephemeral and postgreSQL persistence in dev and production profiles (apache#337)
* Added Persistence field in SonataFlow CRD

Signed-off-by: Jordi Gil <[email protected]>

* Added implementation to manage PostgreSQL persistence type in the SonataFlow CRD

Signed-off-by: Jordi Gil <[email protected]>

* Added end to end tests

Signed-off-by: Jordi Gil <[email protected]>

* Retry health endpoints

Signed-off-by: Jordi Gil <[email protected]>

* Changes based on Ricardo's feedback

Signed-off-by: Jordi Gil <[email protected]>

* Reorganized persistence e2e test and tweaked health check to cover for worfklows that end very quickly, like callbackstatetimeouts

Signed-off-by: Jordi Gil <[email protected]>

* Changes after merge conflicts with platform e2e tests

Signed-off-by: Jordi Gil <[email protected]>

* Added additional check for failing test in workflowproj

Signed-off-by: Jordi Gil <[email protected]>

---------

Signed-off-by: Jordi Gil <[email protected]>
…pache#362)

* Fix apache#359 - Change pullpolicy conditionally based on image tag

Signed-off-by: Ricardo Zanini <[email protected]>

* Fix leftovers on rebase

Signed-off-by: Ricardo Zanini <[email protected]>

---------

Signed-off-by: Ricardo Zanini <[email protected]>
@rgdoliveira
Copy link
Member Author

Just syncing the main branch with Apache main as it was done only once when I first created the serverless-operator midstream main branch.

@rgdoliveira rgdoliveira merged commit 11ab49a into kiegroup:main Jan 30, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants