Skip to content

Added a filesystem storage#342

Merged
marlonbaeten merged 2 commits intomainfrom
filesystem-storage
Feb 26, 2026
Merged

Added a filesystem storage#342
marlonbaeten merged 2 commits intomainfrom
filesystem-storage

Conversation

@marlonbaeten
Copy link
Contributor

Write events as json to a stream file, line by line.
This enables running the application on a desktop computer (without a database server).

Note that we do not yet encrypt the data, but will de so in the future.

@marlonbaeten marlonbaeten self-assigned this Feb 23, 2026
@github-actions
Copy link

github-actions bot commented Feb 23, 2026

Sigrid maintainability feedback

⏸️️ Your are still below your objective of 3.5 stars.

Show details

Sigrid compared your code against the baseline of 2026-02-26.

👍 What went well?

You fixed or improved 2 refactoring candidates.

Risk System property Location
🟡 Unit Size
(Improved)
src/store/database.rs
update_in_database(Store<D>,sqlx
PgPool,D
Event)
🟡 Unit Interfacing
(Improved)
src/store/database.rs
update_in_database(Store<D>,sqlx
PgPool,D
Event)

👎 What could be better?

Unfortunately, 7 refactoring candidates were introduced or got worse.

Risk System property Location
🟠 Unit Size
(Worsened)
src/store/mod.rs
StorePersistence.from_storage_url(str)
🟠 Unit Size
(Introduced)
src/store/filesystem.rs
replay_from_file(Store<D>,Path)
🟠 Module Coupling
(Worsened)
src/store/persistance.rs
🟠 Module Coupling
(Worsened)
src/store/mod.rs
🟡 Unit Size
(Introduced)
src/store/filesystem.rs
append_once(Path,StoreEvent<E>)
🟡 Unit Complexity
(Introduced)
src/store/filesystem.rs
replay_from_file(Store<D>,Path)
🟡 Unit Interfacing
(Introduced)
src/store/filesystem.rs
update_in_filesystem(Store<D>,Path,D
Event)

📚 Remaining technical debt

5 refactoring candidates didn't get better or worse, but are still present in the code you touched.

View this system in Sigrid to explore your technical debt

⭐️ Sigrid ratings

System property System on 2026-02-26 Before changes New/changed code
Volume 4.8 N/A N/A
Duplication 3.6 5.5 5.5
Unit Size 3.3 2.6 2.3
Unit Complexity 4.4 5.5 4.0
Unit Interfacing 2.4 2.6 3.2
Module Coupling 4.0 0.5 0.9
Component Independence 2.7 N/A N/A
Component Entanglement 3.0 N/A N/A
Maintainability 3.6 3.3 3.0

💬 Did you find this feedback helpful?

We would like to know your thoughts to make Sigrid better.
Your username will remain confidential throughout the process.


View this system in Sigrid

@marlonbaeten marlonbaeten marked this pull request as draft February 26, 2026 08:38
@marlonbaeten marlonbaeten marked this pull request as ready for review February 26, 2026 13:23
@marlonbaeten marlonbaeten enabled auto-merge (squash) February 26, 2026 13:23
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 26, 2026

@marlonbaeten marlonbaeten merged commit ce85028 into main Feb 26, 2026
9 checks passed
@marlonbaeten marlonbaeten deleted the filesystem-storage branch February 26, 2026 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants