-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert scripts to the format used by console_scripts #493
Convert scripts to the format used by console_scripts #493
Conversation
|
@kislyuk Did you look at this? Want me to make a separate PR to fix CI? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@segevfiner thanks for your contribution, but can you please change the git history such that the move is explicitly reflected? In other words, git mv
the files from one place to the other, then add new files in their place with no commonality with the original files.
I can't review this PR as it is because there is no diff reflecting any changes (or lack thereof) made in the move.
|
||
import argcomplete | ||
|
||
__package__ = "argcomplete" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this set? Please either document a reason why this needs to be set in a comment, or remove this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a comment
Just an FYI: A |
a7127b0
to
ed3f9ed
Compare
@kislyuk Fixes committed. |
Thanks, merged |
@kislyuk
Split from #474