datasource_nrf_51822: filter packets that fail CRC validation - #621
Merged
kismetwireless merged 1 commit intoJul 28, 2026
Merged
Conversation
Add an else branch alongside the existing valid-packet handling to set packet->filtered = true when checksum_valid is false, so invalid packets are dropped before they can create or update a device. Previously there was no such branch: invalid packets fell straight through with no packet data attached at all, likely the root cause of the sustained under-detection reported in kismetwireless#399.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an else branch alongside the existing valid-packet handling to set packet->filtered = true when checksum_valid is false. Previously there was no such branch: invalid packets fell straight through with no packet data attached at all, likely the root cause of the sustained under-detection reported in #399; see the end of this conversation. This will allow for invalid packet counters to increment.