devicetracker: don't set peak location from packets without a GPS fix - #622
Merged
kismetwireless merged 1 commit intoAug 3, 2026
Merged
Conversation
The refactor making gps a permanent packet component (38186dc) left kis_tracked_signal_data::append_signal guarding the peak location update with only a null check on the gps pointer. Since devicetracker now passes &in_pack->gps_info unconditionally (update_common_device and inc_seenby_count), the pointer is never null and any packet that set a new max signal without a GPS fix overwrote peak_loc with a zeroed location at 0,0. Require gps_info_ok in both the dbm and rssi branches, matching the gps_info_ok checks the refactor added elsewhere in devicetracker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The refactor making gps a permanent packet component (38186dc) left kis_tracked_signal_data::append_signal guarding the peak location update with only a null check on the gps pointer. Since devicetracker now passes &in_pack->gps_info unconditionally (update_common_device and inc_seenby_count), the pointer is never null and any packet that set a new max signal without a GPS fix overwrote peak_loc with a zeroed location at 0,0.
Require gps_info_ok in both the dbm and rssi branches, matching the gps_info_ok checks the refactor added elsewhere in devicetracker.