Skip to content

PR for v1.2.6 #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 107 commits into
base: main
Choose a base branch
from
Open

PR for v1.2.6 #403

wants to merge 107 commits into from

Conversation

ThomasJejkal
Copy link
Contributor

@ThomasJejkal ThomasJejkal commented Jan 27, 2025

Summary by CodeRabbit

  • Chores
    • Enhanced continuous integration workflows with an updated Java environment.
    • Upgraded internal plugins and dependency versions to boost performance, security, and stability.
    • Advanced the build system for a more reliable build process.

renovate bot and others added 2 commits January 26, 2025 20:44

Verified

This commit was signed with the committer’s verified signature.
cafkafk Christina Sørensen
Update springDocVersion to v2.8.4
Copy link
Contributor

coderabbitai bot commented Jan 27, 2025

"""

Walkthrough

This pull request updates several GitHub Actions workflows by upgrading the actions/setup-java action from version v4.6.0 to v4.7.1. It also upgrades multiple plugin and dependency versions in the build configuration, including Spring Boot, Jackson, and others. The Gradle wrapper is updated from version 8.12.1 to 8.14. The Gradle wrapper scripts (gradlew and gradlew.bat) are modified to switch from classpath-based Java invocation to jar-based execution and clarify comments. These changes focus on version bumps and script invocation improvements without altering workflow logic or build control flow.

Changes

File(s) Change Summary
.github/workflows/codeql-analysis.yml, .github/workflows/gradle.yml, .github/workflows/publishRelease.yml Updated actions/setup-java action version from v4.6.0 to v4.7.1 for Java environment setup in workflows.
build.gradle Upgraded multiple plugin versions (io.freefair.lombok, io.freefair.maven-publish-java, org.owasp.dependencycheck) and dependency versions including Spring Boot, Spring Doc, Javers, Spring Messaging, Elasticsearch, Commons IO, Commons Collections4, Commons Text, Apache Tika, Gson, Jackson modules, and Spring Boot Admin Starter Client; also updated Jacoco plugin tool version.
gradle/wrapper/gradle-wrapper.properties Updated Gradle wrapper distributionUrl from version 8.12.1 to 8.14.
gradlew, gradlew.bat Changed Gradle wrapper Java invocation from classpath-based with main class to jar-based execution using -jar option; cleared CLASSPATH variable; removed duplicated JAVA_OPTS mention in comment.

Sequence Diagram(s)

Possibly related PRs

  • PR for v1.2.4 #359: Previous update of actions/setup-java version from v4.5.0 to v4.6.0 in similar workflow files, related to the same workflows and action usage.

Poem

I'm a rabbit with agile hops,
Upgrading workflows 'til the code stops.
New versions, plugins, and fixes in sight,
Jumping through scripts with all my might.
Jar-based runs now take the stage,
Keeping builds fresh, page by page. 🐇
Cheers to upgrades that keep things light!
"""

Tip

⚡️ Faster reviews with caching
  • CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9e159c3 and 7c6cf22.

📒 Files selected for processing (1)
  • build.gradle (5 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • build.gradle
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Analyze (java)
  • GitHub Check: build (windows-latest, 19)
  • GitHub Check: build (windows-latest, 17)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

renovate bot and others added 27 commits January 29, 2025 05:27
…-spring-boot-admin-starter-client-3.x

Update dependency de.codecentric:spring-boot-admin-starter-client to v3.4.2
…mbok-8.x

Update plugin io.freefair.lombok to v8.12.1
…ndencycheck-12.x

Update plugin org.owasp.dependencycheck to v12.0.2
…a-tika-core-3.x

Update dependency org.apache.tika:tika-core to v3.1.0
…e.gson-gson-2.x

Update dependency com.google.code.gson:gson to v2.12.1
…java-4.x

Update actions/setup-java action to v4.7.0
…ven-publish-java-8.x

Update plugin io.freefair.maven-publish-java to v8.12.1
…ework.data-spring-data-elasticsearch-5.x

Update dependency org.springframework.data:spring-data-elasticsearch to v5.4.3
…ework-spring-messaging-6.x

Update dependency org.springframework:spring-messaging to v6.2.3
…ndencycheck-12.x

Update plugin org.owasp.dependencycheck to v12.1.0
Update dependency org.javers:javers-spring-boot-starter-sql to v7.8.0
Update springDocVersion to v2.8.5
renovate bot and others added 25 commits April 22, 2025 11:13
Update dependency jacoco to v0.8.13
…ndencycheck-12.x

Update plugin org.owasp.dependencycheck to v12.1.1
…a to v2.19.0
…java-4.x

Update actions/setup-java action to v4.7.1
…e.gson-gson-2.x

Update dependency com.google.code.gson:gson to v2.13.1
…mons-commons-text-1.x

Update dependency org.apache.commons:commons-text to v1.13.1
…310 to v2.19.0
…mons-io-2.x

Update dependency commons-io:commons-io to v2.19.0
…ework-spring-messaging-6.x

Update dependency org.springframework:spring-messaging to v6.2.6
…ework.data-spring-data-elasticsearch-5.x

Update dependency org.springframework.data:spring-data-elasticsearch to v5.4.5
…ider to v2.19.0
…mons-commons-collections4-4.x

Update dependency org.apache.commons:commons-collections4 to v4.5.0
Update dependency org.springframework.boot:spring-boot-dependencies to v3.4.5
…jackson.datatype-jackson-datatype-joda-2.x

Update dependency com.fasterxml.jackson.datatype:jackson-datatype-joda to v2.19.0
…pe-jackson-datatype-jsr310-2.x
…jackson.jaxrs-jackson-jaxrs-json-provider-2.x

Update dependency com.fasterxml.jackson.jaxrs:jackson-jaxrs-json-provider to v2.19.0
…jackson.datatype-jackson-datatype-jsr310-2.x

Update dependency com.fasterxml.jackson.datatype:jackson-datatype-jsr310 to v2.19.0
Update dependency gradle to v8.14
…rner to v2.19.0
…jackson.module-jackson-module-afterburner-2.x

Update dependency com.fasterxml.jackson.module:jackson-module-afterburner to v2.19.0
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (2)
gradlew.bat (1)

73-78: -classpath is redundant (and ignored) when -jar is supplied
java -jar … makes the JVM ignore any -classpath argument that precedes it, so

set CLASSPATH=
"%JAVA_EXE%" … -classpath "%CLASSPATH%" -jar "%APP_HOME%\gradle\wrapper\gradle-wrapper.jar"

passes an unused, empty class-path. Dropping both the variable and the flag simplifies the command and avoids confusion for anybody debugging class-path issues later.

-set CLASSPATH=
-"%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -classpath "%CLASSPATH%" -jar "%APP_HOME%\gradle\wrapper\gradle-wrapper.jar" %*
+"%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -jar "%APP_HOME%\gradle\wrapper\gradle-wrapper.jar" %*
gradlew (1)

207-217: Remove unused -classpath argument for clarity
The POSIX script still appends -classpath "$CLASSPATH" before -jar …. As in the Windows batch file, the flag does nothing and clutters the argument list.

-        -classpath "$CLASSPATH" \
-        -jar "$APP_HOME/gradle/wrapper/gradle-wrapper.jar" \
+        -jar "$APP_HOME/gradle/wrapper/gradle-wrapper.jar" \

This keeps the launch command minimal and avoids the need to maintain (or explain) the dummy CLASSPATH variable.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4a40236 and 9e159c3.

⛔ Files ignored due to path filters (1)
  • gradle/wrapper/gradle-wrapper.jar is excluded by !**/*.jar
📒 Files selected for processing (4)
  • build.gradle (5 hunks)
  • gradle/wrapper/gradle-wrapper.properties (1 hunks)
  • gradlew (2 hunks)
  • gradlew.bat (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • build.gradle
⏰ Context from checks skipped due to timeout of 90000ms (13)
  • GitHub Check: build (windows-latest, 19)
  • GitHub Check: build (macOS-latest, 19)
  • GitHub Check: build (macOS-latest, 17)
  • GitHub Check: build (ubuntu-latest, 17)
  • GitHub Check: build (windows-latest, 17)
  • GitHub Check: build (ubuntu-latest, 19)
  • GitHub Check: Analyze (java)
  • GitHub Check: build (windows-latest, 17)
  • GitHub Check: build (macOS-latest, 19)
  • GitHub Check: build (windows-latest, 19)
  • GitHub Check: build (ubuntu-latest, 19)
  • GitHub Check: build (macOS-latest, 17)
  • GitHub Check: build (ubuntu-latest, 17)
🔇 Additional comments (1)
gradle/wrapper/gradle-wrapper.properties (1)

3-3: Gradle 8.14 upgrade – verify build & plugin compatibility
Jumping two minor versions is normally painless, but some community plugins (e.g. spring-boot, jib, shadow) are occasionally sensitive to Gradle internals. Please make sure the CI matrix runs all tasks (clean build test integrationTest etc.) on 8.14 before merging and watch out for deprecation warnings so you are not surprised in the next upgrade.

Comment on lines +117 to 118
CLASSPATH="\\\"\\\""

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

CLASSPATH="\\\"\\\"" expands to the literal string "\"", not an empty class-path
That value is harmless because Java will ignore -classpath once -jar is also provided, but it is confusing when someone echoes the variable while troubleshooting.

-CLASSPATH="\\\"\\\""
+# Intentionally empty – Gradle wrapper is started via -jar, so class-path is irrelevant
+CLASSPATH=
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
CLASSPATH="\\\"\\\""
# Intentionally empty – Gradle wrapper is started via -jar, so class-path is irrelevant
CLASSPATH=

renovate bot and others added 4 commits May 2, 2025 14:27
Update springDocVersion to v2.8.8
…nager-service-base-1.x

Update dependency edu.kit.datamanager:service-base to v1.3.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants