-
Notifications
You must be signed in to change notification settings - Fork 2
PR for v1.2.6 #403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
PR for v1.2.6 #403
Conversation
Update springDocVersion to v2.8.4
""" WalkthroughThis pull request updates several GitHub Actions workflows by upgrading the Changes
Sequence Diagram(s)Possibly related PRs
Poem
Tip ⚡️ Faster reviews with caching
Enjoy the performance boost—your workflow just got faster. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
…v3.4.2
…-spring-boot-admin-starter-client-3.x Update dependency de.codecentric:spring-boot-admin-starter-client to v3.4.2
…mbok-8.x Update plugin io.freefair.lombok to v8.12.1
…ndencycheck-12.x Update plugin org.owasp.dependencycheck to v12.0.2
…a-tika-core-3.x Update dependency org.apache.tika:tika-core to v3.1.0
…e.gson-gson-2.x Update dependency com.google.code.gson:gson to v2.12.1
…java-4.x Update actions/setup-java action to v4.7.0
…ven-publish-java-8.x Update plugin io.freefair.maven-publish-java to v8.12.1
…to v5.4.3
…ework.data-spring-data-elasticsearch-5.x Update dependency org.springframework.data:spring-data-elasticsearch to v5.4.3
…ework-spring-messaging-6.x Update dependency org.springframework:spring-messaging to v6.2.3
…ndencycheck-12.x Update plugin org.owasp.dependencycheck to v12.1.0
Update dependency org.javers:javers-spring-boot-starter-sql to v7.8.0
Update springDocVersion to v2.8.5
…o v3.4.3
…v3.4.4
…to v5.4.5
…o v3.4.5
Update dependency jacoco to v0.8.13
…ndencycheck-12.x Update plugin org.owasp.dependencycheck to v12.1.1
…a to v2.19.0
…java-4.x Update actions/setup-java action to v4.7.1
…e.gson-gson-2.x Update dependency com.google.code.gson:gson to v2.13.1
…mons-commons-text-1.x Update dependency org.apache.commons:commons-text to v1.13.1
…310 to v2.19.0
…mons-io-2.x Update dependency commons-io:commons-io to v2.19.0
…ework-spring-messaging-6.x Update dependency org.springframework:spring-messaging to v6.2.6
…ework.data-spring-data-elasticsearch-5.x Update dependency org.springframework.data:spring-data-elasticsearch to v5.4.5
…ider to v2.19.0
…mons-commons-collections4-4.x Update dependency org.apache.commons:commons-collections4 to v4.5.0
Update dependency org.springframework.boot:spring-boot-dependencies to v3.4.5
…jackson.datatype-jackson-datatype-joda-2.x Update dependency com.fasterxml.jackson.datatype:jackson-datatype-joda to v2.19.0
…pe-jackson-datatype-jsr310-2.x
…jackson.jaxrs-jackson-jaxrs-json-provider-2.x Update dependency com.fasterxml.jackson.jaxrs:jackson-jaxrs-json-provider to v2.19.0
…jackson.datatype-jackson-datatype-jsr310-2.x Update dependency com.fasterxml.jackson.datatype:jackson-datatype-jsr310 to v2.19.0
Update dependency gradle to v8.14
…rner to v2.19.0
…jackson.module-jackson-module-afterburner-2.x Update dependency com.fasterxml.jackson.module:jackson-module-afterburner to v2.19.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
gradlew.bat (1)
73-78
:-classpath
is redundant (and ignored) when-jar
is supplied
java -jar …
makes the JVM ignore any-classpath
argument that precedes it, soset CLASSPATH= "%JAVA_EXE%" … -classpath "%CLASSPATH%" -jar "%APP_HOME%\gradle\wrapper\gradle-wrapper.jar"passes an unused, empty class-path. Dropping both the variable and the flag simplifies the command and avoids confusion for anybody debugging class-path issues later.
-set CLASSPATH= -"%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -classpath "%CLASSPATH%" -jar "%APP_HOME%\gradle\wrapper\gradle-wrapper.jar" %* +"%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -jar "%APP_HOME%\gradle\wrapper\gradle-wrapper.jar" %*gradlew (1)
207-217
: Remove unused-classpath
argument for clarity
The POSIX script still appends-classpath "$CLASSPATH"
before-jar …
. As in the Windows batch file, the flag does nothing and clutters the argument list.- -classpath "$CLASSPATH" \ - -jar "$APP_HOME/gradle/wrapper/gradle-wrapper.jar" \ + -jar "$APP_HOME/gradle/wrapper/gradle-wrapper.jar" \This keeps the launch command minimal and avoids the need to maintain (or explain) the dummy
CLASSPATH
variable.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
gradle/wrapper/gradle-wrapper.jar
is excluded by!**/*.jar
📒 Files selected for processing (4)
build.gradle
(5 hunks)gradle/wrapper/gradle-wrapper.properties
(1 hunks)gradlew
(2 hunks)gradlew.bat
(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- build.gradle
⏰ Context from checks skipped due to timeout of 90000ms (13)
- GitHub Check: build (windows-latest, 19)
- GitHub Check: build (macOS-latest, 19)
- GitHub Check: build (macOS-latest, 17)
- GitHub Check: build (ubuntu-latest, 17)
- GitHub Check: build (windows-latest, 17)
- GitHub Check: build (ubuntu-latest, 19)
- GitHub Check: Analyze (java)
- GitHub Check: build (windows-latest, 17)
- GitHub Check: build (macOS-latest, 19)
- GitHub Check: build (windows-latest, 19)
- GitHub Check: build (ubuntu-latest, 19)
- GitHub Check: build (macOS-latest, 17)
- GitHub Check: build (ubuntu-latest, 17)
🔇 Additional comments (1)
gradle/wrapper/gradle-wrapper.properties (1)
3-3
: Gradle 8.14 upgrade – verify build & plugin compatibility
Jumping two minor versions is normally painless, but some community plugins (e.g. spring-boot, jib, shadow) are occasionally sensitive to Gradle internals. Please make sure the CI matrix runs all tasks (clean build test integrationTest
etc.) on 8.14 before merging and watch out for deprecation warnings so you are not surprised in the next upgrade.
CLASSPATH="\\\"\\\"" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
CLASSPATH="\\\"\\\""
expands to the literal string "\""
, not an empty class-path
That value is harmless because Java will ignore -classpath
once -jar
is also provided, but it is confusing when someone echoes the variable while troubleshooting.
-CLASSPATH="\\\"\\\""
+# Intentionally empty – Gradle wrapper is started via -jar, so class-path is irrelevant
+CLASSPATH=
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
CLASSPATH="\\\"\\\"" | |
# Intentionally empty – Gradle wrapper is started via -jar, so class-path is irrelevant | |
CLASSPATH= |
Update springDocVersion to v2.8.8
…nager-service-base-1.x Update dependency edu.kit.datamanager:service-base to v1.3.4
Summary by CodeRabbit