Added height checks to ensure touch is inside the nav drawer or its main panel#8
Open
mrhubbs wants to merge 1 commit intokivy-garden:masterfrom
Open
Added height checks to ensure touch is inside the nav drawer or its main panel#8mrhubbs wants to merge 1 commit intokivy-garden:masterfrom
mrhubbs wants to merge 1 commit intokivy-garden:masterfrom
Conversation
…r its main panel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug in that the navigation drawer will grab touches which are vertically above or below it.
Referring to the image below, I've circled the button in the Android Gmail app which opens the Gmail navigation drawer. In the previous implementation of Kivy's navigation drawer, it would be impossible to touch that button. The navigation drawer did not perform checks on the touch's vertical position and would erroneously grab the touch.