Skip to content

Conversation

@maho
Copy link
Contributor

@maho maho commented Jan 23, 2017

This commit fixes problem with flickering.

Testcase - https://github.com/mahomahomaho/kivent-memory-issue-case

Before this pull request:
0. - frame is rendered properly

    • 1sec later, texture_set is set to next texture, frame gets blank
    • 1sec later, frame is rendered properly
  1. goto 0.

after pull request, whole texture_set is scheduled and executed in the beginning of Gameworld.update()

It's very likely that coding style is against your coding style, then please give guidelines or fix yourself.

@Kovak
Copy link
Contributor

Kovak commented Sep 7, 2017

The only thing I don't like about this PR is the naming of schedule_once. It A: is not very descriptive, it should be something like schedule_before_update_callback or something else descriptive of what it does. and B: The name shadows Clock.schedule_once which is a bit confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants