Added an Ability to Save & View Web History (#1368) #1404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thank you for this PR. I'll take a look, but please note what it says in CONTRIBUTING about asking to be assigned to an issue before starting work on a PR. I can see that you placed a button on the Home page for this, but as we will soon be switching to a UI like Kiwix JS PWA, there won't be room for such buttons in that layout, as we need only a minimal UI on the Home page, and other options in Configuration. However, I suggest you await my checking your work before working on this further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Worked on an open issue: "Provide Web browser history feature as an option #1368". Implemented the feature by saving the articles user opened to the localStorage. On each access, save the title, its ID, and the timestamp. Users can view the history by clicking on the button with a logo taken from Font Awesome, can hide the history and delete it as well.