Skip to content

added webdriver_manager support to auto-install gecko webdriver #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yanncabral wants to merge 2 commits into
base: master
Choose a base branch
from
Open

added webdriver_manager support to auto-install gecko webdriver #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f13812
added webdriver_manager support to auto-install gecko webdriver
yanncabral Aug 24, 2020
fdd9f3b
added auto-install as optional and default_path as default
yanncabral Aug 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions selenium_firefox/Firefox.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
import pickle, os, time, json

# Pip
from webdriver_manager.firefox import GeckoDriverManager

from selenium import webdriver
from selenium.webdriver.support.ui import WebDriverWait
from selenium.webdriver.common.keys import Keys
Expand Down Expand Up @@ -52,7 +54,8 @@ def __init__(
manual_set_timezone: bool = False,
user_agent: Optional[str] = None,
load_proxy_checker_website: bool = False,
disable_images: bool = False
disable_images: bool = False,
geckodriver_path: Optional[str] = 'geckodriver'
):
'''EITHER PROVIDE 'cookies_id' OR 'cookies_folder_path'.
IF 'cookies_folder_path' is None, 'cokies_id', will be used to calculate 'cookies_folder_path'
Expand Down Expand Up @@ -127,7 +130,11 @@ def __init__(
options.add_argument("--width=" + str(screen_size[0]))
options.add_argument("--height=" + str(screen_size[1]))

self.driver = webdriver.Firefox(firefox_profile=profile, firefox_options=options)
if not (geckodriver_path and os.path.exists(geckodriver_path)):
print('GeckoDriver not found at "', geckodriver_path, '". It will be installed')
geckodriver_path = GeckoDriverManager().install()

self.driver = webdriver.Firefox(executable_path=geckodriver_path, firefox_profile=profile, firefox_options=options)

if full_screen:
self.driver.fullscreen_window()
Expand Down