-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev: expose serialize
in RustVM pythonic hints
#887
Merged
Merged
+280
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enitrat
commented
Feb 27, 2025
e3d2402
to
d875877
Compare
d875877
to
adea8c2
Compare
ClementWalter
previously approved these changes
Feb 28, 2025
Co-authored-by: Clément Walter <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #887 +/- ##
==========================================
- Coverage 81.92% 78.24% -3.69%
==========================================
Files 64 64
Lines 15320 16746 +1426
==========================================
+ Hits 12551 13103 +552
- Misses 2769 3643 +874
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes a
serialize
function, available in the scope of all hints, that enables the serialization usingserde
of cairo types, and returns their python representation.This can be used for the logging / tracing system.
I am welcoming any alternative idea on the currently proposed design - as working with python
globals()
has been quite a hassle.Also, i'm not sure yet how we can make this entirely transparent with the pythonVM runs. If we realize there's a need for that, we can do it later.
This does introduce a small performance overhead of about ~5% from what i've observed empirically. So in production we'll need to make sure we're not compiling with this flag.
Closes #883