Version 5.3.1#566
Draft
belleklaviyo wants to merge 3 commits intorel/5.3.0from
Draft
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1119b29. Configure here.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…564) * spike(extension): copy shared types into KlaviyoSwiftExtension, drop KlaviyoCore dep Copy ActionType, KlaviyoCategoryManager (register-only), Logger+Ext, and UNNotificationContent+Klaviyo directly into KlaviyoSwiftExtension so the extension target no longer needs KlaviyoCore. The NSE sandbox prevents sharing a framework across app and extension targets in some configurations. Remove KlaviyoCore from Package.swift (production + test targets) and from KlaviyoSwiftExtension.podspec. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * spike(core): restore pruning in KlaviyoCore, annotate intentional duplication Restore KlaviyoCore/KlaviyoCategoryManager with prune-only functionality and re-wire pruneCategory through KlaviyoSwiftEnvironment + Klaviyo.swift. KlaviyoSwiftExtension retains its register-only copy; pruning is not duplicated. Add sync notes to both KlaviyoCategoryManager copies and both ActionType copies explaining the intentional duplication and the NSE sandbox reason for it. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(tests): stub KlaviyoSwiftEnvironment in setup, update snapshots setUpWithError was leaving klaviyoSwiftEnvironment at .production, causing handle(notificationResponse:) tests to hit the real UNUserNotificationCenter via the pruneCategory defer block. Stub it in setUp so tests are isolated. Update EncodableTest snapshots to reflect current state. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * docs: note v5.3.0 KlaviyoSwiftExtension incompatibility with NSE targets Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patches the Cocoapods issue