Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates email.js to correctly handle the klaviyo object promise #319

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

cykolln
Copy link
Contributor

@cykolln cykolln commented Feb 25, 2025

Description

addresses #306 by adding the correct handling for the promise returned from klaviyo.isIdentified(). This fixes a bug where we weren't correctly identifying profiles from the checkout page.

Manual Testing Steps

  1. tested new behavior on a local magento site, valildated the klaviyo profile was correctly created.

Pre-Submission Checklist:

  • You've updated the CHANGELOG following the steps here
  • Internal Only - If this is a release, please confirm the following:
    • The links in the changelog have been updated to point towards the new versions
    • The version has been incremented in the following places: module.xml and composer.json

NOTE: Please use the Changelogger cli tool to manage versioned file upgrades.

@cykolln cykolln requested a review from a team as a code owner February 25, 2025 15:43
Copy link
Contributor

@smoucka smoucka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cykolln cykolln merged commit 2003a06 into master Feb 25, 2025
7 checks passed
@cykolln cykolln deleted the 202502_BUGPORT-5813 branch February 25, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants