Adds external_catalog_id and integration_key to M2 events. #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cykolln
force-pushed
the
202503_poc_external_catalog_id
branch
from
3f69d61 to
d6203c8
Compare
cykolln
changed the title
cykolln
commented
Mar 26, 2025
| @@ -396,8 +394,7 @@ public function buildEventProperties($eventProperties, $time, $metric) | |||
| self::DATA_KEY_PAYLOAD => array( | |||
| self::TYPE_KEY_PAYLOAD => self::METRIC_KEY_PAYLOAD, | |||
| self::ATTRIBUTE_KEY_PAYLOAD => array( | |||
| self::NAME_KEY_PAYLOAD => $metric, | |||
| self::SERVICE_PAYLOAD_KEY => self::MAGENTO_TWO_INTEGRATION_SERVICE_KEY | |||
There was a problem hiding this comment.
removed this, its wrong!
There was a problem hiding this comment.
a) we don't want this branded, which is what service does
b) the integration key is incorrect anyways - magento_two not magentotwo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds external_catalog_id and integration_key to the two events that are shipped from the magento 2 extension: Viewed Product, and Added to Cart.
Manual Testing Steps
Pre-Submission Checklist:
NOTE: Please use the Changelogger cli tool to manage versioned file upgrades.