-
Notifications
You must be signed in to change notification settings - Fork 7
Chore/updated relayer encoding fix #430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Changes from all commits
a6fe48f
dabf0c2
1a20744
698c1e8
037aea1
9544a8d
7f77e5d
96a56dc
f1a4165
78efc27
6bf3b15
eb9f428
717e89e
7c7b750
9afd65c
9bf7c9a
a16ccf9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,10 +12,9 @@ interface IVeaInbox { | |
/// @dev Sends an arbitrary message to receiving chain. | ||
/// Note: Calls authenticated by receiving gateway checking the sender argument. | ||
/// @param _to The cross-domain contract address which receives the calldata. | ||
/// @param _fnSelection The function selector of the receiving contract. | ||
/// @param _data The message calldata, abi.encode(...) | ||
/// @param _data The message calldata, abi.encodeWithSelector(...) | ||
/// @return msgId The index of the message in the inbox, as a message Id, needed to relay the message. | ||
function sendMessage(address _to, bytes4 _fnSelection, bytes memory _data) external returns (uint64 msgId); | ||
function sendMessage(address _to, bytes calldata _data) external returns (uint64 msgId); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Verification agent 🧩 Analysis chainLocate and update all callers to the new 2-arg signature Make sure internal tools, relayers, and tests no longer pass a separate selector/arg. 🏁 Script executed: #!/bin/bash
# Find old-style 3-arg calls
rg -n -A1 -B2 $'sendMessage\\s*\\(\\s*[^,]+,\\s*[^,]+,\\s*[^)]*\\)' -g '!**/interfaces/**'
# List all sendMessage calls for manual review
rg -n -A1 -B2 $'sendMessage\\s*\\(' Length of output: 312375 Update all The inbox Affected call sites:
Ensure the passed 🤖 Prompt for AI Agents
|
||
|
||
/// @dev Snapshots can be saved a maximum of once per epoch. | ||
/// Saves snapshot of state root. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parameter documentation is incomplete.
The NatSpec comment for the
_from
parameter doesn't match the actual parameter name or purpose correctly.Apply this diff to fix the documentation:
📝 Committable suggestion
🤖 Prompt for AI Agents