Fix: make build should build kmeshctl
#1214
Conversation
|
@adwait-godbole: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Welcome @adwait-godbole! It looks like this is your first PR to kmesh-net/kmesh 🎉 |
Signed-off-by: adwait-godbole <[email protected]>
Signed-off-by: adwait-godbole <[email protected]>
adwait-godbole
force-pushed
the
fix-make-build
branch
from
2db9afb to
a698491
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Continue to review full report in Codecov by Sentry.
|
| @@ -17,5 +17,6 @@ COPY out/oncn-mda.conf /etc/oncn-mda/ | |||
| COPY out/kmesh-daemon /usr/bin/ | |||
| COPY out/kmesh-cni /usr/bin/ | |||
| COPY out/mdacore /usr/bin/ | |||
| COPY out/kmeshctl /usr/bin/ | |||
There was a problem hiding this comment.
remove it, kmeshctl is not needed by the docker image
| @@ -23,4 +23,5 @@ COPY --from=builder /kmesh/oncn-mda/etc/oncn-mda.conf /usr/share/oncn-mda/ | |||
| COPY --from=builder /usr/bin/kmesh-daemon /usr/bin/ | |||
| COPY --from=builder /usr/bin/kmesh-cni /usr/bin/ | |||
| COPY --from=builder /usr/bin/mdacore /usr/bin/ | |||
| COPY --from=builder /usr/bin/kmeshctl /usr/bin/ | |||
Fixes #1113
/kind bug