implemented e2e test on log #1242
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
test/e2e/log_test.go
Outdated
|
|
||
| func TestLoggerEndToEnd(t *testing.T) { | ||
| // Mock HTTP server for Kmesh daemon pod | ||
| server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { |
There was a problem hiding this comment.
You should use the real Kmesh daemon instead of a mock.
We have installed Kmesh in https://github.com/kmesh-net/kmesh/blob/main/test/e2e/run_test.sh
test/e2e/log_test.go
Outdated
|
|
||
| // Test cases | ||
| t.Run("Get all loggers", func(t *testing.T) { | ||
| output := captureOutput(func() { |
There was a problem hiding this comment.
Also use the real kmeshctl binary to test.
|
@YaoZengzeng I have made the changes you asked for |
|
@harshitghagre you should pass the test case you have wrote, as well as the rest of the CI. |
What type of PR is this?
/kind enhancement
What this PR does:
e2e test for the log package
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: