-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(authz): Add E2E test for kmeshctl authz functionality #1243
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Ravjot Singh <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
||
// 2) Enable Authz on the Kmesh Daemon Pod | ||
t.Run("enable-authz", func(t *testing.T) { | ||
cmd := fmt.Sprintf("kmeshctl authz enable %s", podName) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should install kmeshctl
in e2e cluster first, refer to what I have done in another PR: test/e2e/run_test.sh
of https://github.com/kmesh-net/kmesh/pull/641/files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okiee @YaoZengzeng i will take a look into this file and update this... really appreciate your guidance
Also make sure you pass the test case you have wrote, as well as the rest of the CI. |
Yup, actually ci issues was with the previous pr it will be fixed once other pr got merged.. |
I will trying to get hold of this e2e testing and other stuff required for this project, could you guide me through some more resources it will really helpful for me to work with this e2e thing once I got more comfortable in this part |
#1210 (comment) These are all the resources now. If you are selected by LFX, you can help to further improve these. Now you can ask questions directly under this PR :) |
kmeshctl authz
commands (enable, status, disable)kubectl
kmeshctl authz enable <pod>
)kmeshctl authz status <pod>
)kmeshctl authz disable <pod>
)This enhances test coverage for Kmesh authz offloading and ensures functionality works on a live cluster.
Contributes towards: #991