-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Publish threat model in documentation #6263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
evankanderson
wants to merge
3
commits into
knative:main
Choose a base branch
from
evankanderson:publish-threat-model
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,62 +2,6 @@ | |
|
||
This page describes Knative security and disclosure information. | ||
|
||
## Knative threat model | ||
|
||
* [Threat model](https://github.com/knative/community/blob/main/working-groups/security/threat-model.md) | ||
|
||
## Code Signature Verification | ||
|
||
### All platforms | ||
|
||
Our releases from 1.9 are signed with [cosign](https://docs.sigstore.dev/cosign/overview). You can use the following steps to verify our binaries. | ||
|
||
1. Download the files you want, and the `checksums.txt`, `checksum.txt.pem` and `checksums.txt.sig` files from the releases page: | ||
```sh | ||
# this example verifies the 1.10.0 kn cli from the knative/client repository | ||
wget https://github.com/knative/client/releases/download/knative-v1.10.0/checksums.txt | ||
wget https://github.com/knative/client/releases/download/knative-v1.10.0/kn-darwin-amd64 | ||
wget https://github.com/knative/client/releases/download/knative-v1.10.0/checksums.txt.sig | ||
wget https://github.com/knative/client/releases/download/knative-v1.10.0/checksums.txt.pem | ||
``` | ||
1. Verify the signature: | ||
```sh | ||
cosign verify-blob \ | ||
--certificate-identity=signer@knative-releases.iam.gserviceaccount.com \ | ||
--certificate-oidc-issuer=https://accounts.google.com \ | ||
--cert checksums.txt.pem \ | ||
--signature checksums.txt.sig \ | ||
checksums.txt | ||
``` | ||
1. If the signature is valid, you can then verify the SHA256 sums match with the downloaded binary: | ||
```sh | ||
sha256sum --ignore-missing -c checksums.txt | ||
``` | ||
|
||
!!! note | ||
Knative images are signed in `KEYLESS` mode. To learn more about keyless signing, please refer to | ||
[Keyless Signatures](https://github.com/sigstore/cosign/blob/main/KEYLESS.md#keyless-signatures) | ||
Our signing identity(Subject) for our releases is `[email protected]` and the Issuer is `https://accounts.google.com` | ||
|
||
### Apple macOS | ||
|
||
In addition to signing our binaries with `cosign`, we [notarize](https://developer.apple.com/documentation/security/notarizing_macos_software_before_distribution) our macOS binaries. You can use the `codesign` utility to verify our binaries from 1.9 release. You should expect an output that looks | ||
like this. The expected TeamIdentifier is `7R64489VHL` | ||
|
||
``` | ||
codesign --verify -d --verbose=2 ~/Downloads/kn-quickstart-darwin-amd64 | ||
|
||
Executable=/Users/REDACTED/Downloads/kn-quickstart-darwin-amd64 | ||
Identifier=kn-quickstart-darwin-amd64 | ||
... | ||
Authority=Developer ID Application: Mahamed Ali (7R64489VHL) | ||
Authority=Developer ID Certification Authority | ||
Authority=Apple Root CA | ||
Timestamp=3 Oct 2022 at 22:50:07 | ||
... | ||
TeamIdentifier=7R64489VHL | ||
``` | ||
|
||
## Report a vulnerability | ||
|
||
We're extremely grateful for security researchers and users that report vulnerabilities to the Knative Open Source Community. All reports are thoroughly investigated by a set of community volunteers. | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved this to
verifying-cli.md
, as it didn't really fit with the rest of the overview