-
Notifications
You must be signed in to change notification settings - Fork 163
Fix node jsdoc #3030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix node jsdoc #3030
Conversation
|
Welcome @cezar77! It looks like this is your first PR to knative/func 🎉 |
Hi @cezar77. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
33ae3d6
to
32098c2
Compare
Thanks for the submission! You'll need to follow the prompts on the EasyCLA thing before we can merge |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3030 +/- ##
==========================================
+ Coverage 58.46% 59.18% +0.72%
==========================================
Files 134 134
Lines 17251 17251
==========================================
+ Hits 10085 10210 +125
+ Misses 6234 6080 -154
- Partials 932 961 +29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Since this modifies a template, you'll need to run make
and check in the autogeneratedzz_filesystem_generated.go
which includes a serialized version of the template for inclusion in the resultant binary.
Signed-off-by: Matej Vašek <[email protected]>
2132ee1
to
ac32597
Compare
/override unit-tests_func_main |
@matejvasek: matejvasek unauthorized: /override is restricted to Repo administrators, and the following github teams:knative: knative-release-leads client-wg-leads eventing-wg-leads functions-wg-leads productivity-wg-leads serving-wg-leads. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cezar77, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@gauron99 @lkingland plz override unit-tests_func_main |
/override unit-tests_func_main |
@gauron99: Overrode contexts on behalf of gauron99: unit-tests_func_main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Changes
In the file
http/index.js
in the node template a link to the context object is provided, but this link is dead and leads to 404. In this PR we update the link to point to the correct location./kind bug
Fixes #3031
Release Note
Docs