Skip to content

Conversation

cezar77
Copy link

@cezar77 cezar77 commented Sep 9, 2025

Changes

In the file http/index.js in the node template a link to the context object is provided, but this link is dead and leads to 404. In this PR we update the link to point to the correct location.

  • 🐛 Fix bug

/kind bug

Fixes #3031

Release Note

Update the link to the Context object in the JSDoc in the file index.js for the node template.

Docs


@knative-prow knative-prow bot requested a review from jrangelramos September 9, 2025 08:33
@knative-prow knative-prow bot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 9, 2025
@knative-prow knative-prow bot requested a review from nainaz September 9, 2025 08:33
Copy link

linux-foundation-easycla bot commented Sep 9, 2025

CLA Not Signed

Copy link

knative-prow bot commented Sep 9, 2025

Welcome @cezar77! It looks like this is your first PR to knative/func 🎉

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 9, 2025
Copy link

knative-prow bot commented Sep 9, 2025

Hi @cezar77. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lkingland
Copy link
Member

Thanks for the submission! You'll need to follow the prompts on the EasyCLA thing before we can merge

Copy link

codecov bot commented Sep 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.18%. Comparing base (c23e8cf) to head (ac32597).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3030      +/-   ##
==========================================
+ Coverage   58.46%   59.18%   +0.72%     
==========================================
  Files         134      134              
  Lines       17251    17251              
==========================================
+ Hits        10085    10210     +125     
+ Misses       6234     6080     -154     
- Partials      932      961      +29     
Flag Coverage Δ
e2e-tests 40.39% <ø> (+1.34%) ⬆️
integration-tests 53.94% <ø> (+1.64%) ⬆️
unit-tests 46.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lkingland lkingland added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 24, 2025
Copy link
Member

@lkingland lkingland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Since this modifies a template, you'll need to run make and check in the autogeneratedzz_filesystem_generated.go which includes a serialized version of the template for inclusion in the resultant binary.

@matejvasek
Copy link
Contributor

/override unit-tests_func_main

Copy link

knative-prow bot commented Oct 9, 2025

@matejvasek: matejvasek unauthorized: /override is restricted to Repo administrators, and the following github teams:knative: knative-release-leads client-wg-leads eventing-wg-leads functions-wg-leads productivity-wg-leads serving-wg-leads.

In response to this:

/override unit-tests_func_main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2025
Copy link

knative-prow bot commented Oct 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cezar77, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2025
@matejvasek
Copy link
Contributor

@gauron99 @lkingland plz override unit-tests_func_main

@gauron99
Copy link
Contributor

/override unit-tests_func_main

Copy link

knative-prow bot commented Oct 10, 2025

@gauron99: Overrode contexts on behalf of gauron99: unit-tests_func_main

In response to this:

/override unit-tests_func_main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 13, 2025
@knative-prow-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Node template has wrong link in the file index.js leading to 404

5 participants