Skip to content

Conversation

intojhanurag
Copy link
Contributor

@intojhanurag intojhanurag commented Oct 13, 2025

This PR resolves the // TODO comment in cmd/delete_test.go by improving the test coverage for the delete command.

It adds a check to ensure that providing both a --path flag and a function name returns the expected error message:
"only one of --path and [NAME] should be provided"

image

@knative-prow
Copy link

knative-prow bot commented Oct 13, 2025

Welcome @intojhanurag! It looks like this is your first PR to knative/func 🎉

@knative-prow
Copy link

knative-prow bot commented Oct 13, 2025

Hi @intojhanurag. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 13, 2025
@intojhanurag
Copy link
Contributor Author

Hey @gauron99 , Can I get a review for this one ?

@matejvasek
Copy link
Contributor

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 13, 2025
@codecov
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.14%. Comparing base (c23e8cf) to head (c34220f).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3081      +/-   ##
==========================================
+ Coverage   58.46%   59.14%   +0.68%     
==========================================
  Files         134      134              
  Lines       17251    17263      +12     
==========================================
+ Hits        10085    10210     +125     
+ Misses       6234     6092     -142     
- Partials      932      961      +29     
Flag Coverage Δ
e2e-tests 40.33% <ø> (+1.29%) ⬆️
integration-tests 53.90% <ø> (+1.60%) ⬆️
unit-tests 46.23% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gauron99 gauron99 requested review from gauron99 and matejvasek and removed request for dsimansk and jrangelramos October 14, 2025 05:27
@intojhanurag
Copy link
Contributor Author

Hey @matejvasek, all test cases passed now.

@gauron99
Copy link
Contributor

/ok-to-test

@gauron99
Copy link
Contributor

thanks for the contribution!
/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2025
@knative-prow
Copy link

knative-prow bot commented Oct 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, intojhanurag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2025
@knative-prow knative-prow bot merged commit 8c4002c into knative:main Oct 14, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants