Skip to content

Conversation

@norman465
Copy link
Member

Proposed Changes

  • eliminate redundant deployment updates
  • if anything modifies the deployment spec of a knative managed deployment the current logic will do a redundant deployment update every reconile. This is i.e. visible when running with net-istio, which adds
        service.istio.io/canonical-name:
        service.istio.io/canonical-revision:

to spec.template.metadata.labels causing the semantic equality check to fail every reconile.

Release Note

NONE

@knative-prow
Copy link

knative-prow bot commented Jan 27, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: norman465
Once this PR has been reviewed and has the lgtm label, please assign gauron99 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 27, 2026
@knative-prow knative-prow bot requested review from gauron99, linkvt and skonto January 27, 2026 06:28
@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.19%. Comparing base (4004491) to head (a573615).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16361      +/-   ##
==========================================
+ Coverage   80.14%   80.19%   +0.04%     
==========================================
  Files         216      216              
  Lines       13440    13440              
==========================================
+ Hits        10772    10778       +6     
+ Misses       2301     2300       -1     
+ Partials      367      362       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant