Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 1-click unsubscribe docs #800
base: main
Are you sure you want to change the base?
feat: 1-click unsubscribe docs #800
Changes from 2 commits
564cca3
7b77a5d
c3b4929
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be helpful to include a screenshot here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: how do we handle this for tenant-specific preferences? What happens if a
tenant
is applied to a given workflow trigger (either when the email that has the unsub link in it is generated, or after they have clicked it on a different workflow run's email)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should include an example below? Also I think there are a few things we could disambiguate here:
default
preferences."commercial_unsubscribe": true
) to eachPreferenceSet
that is set in Knock, regardless of whether it is provided by the customer's application?true
= send andfalse
= don't send as usual? I think we should probably say this explicitly, because to me a setting of"commercial_unsubscribe": true
reads like "it is true that I have unsubscribed, therefore I will not receive a message" but I think it's actually the opposite based on how our preferences model works.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see we include some of this on the other page under "Preference evaluation rules". I think it doesn't hurt to include at least some of the info in both places, in case someone reads the preferences overview page without looking further into commercial unsub. Perhaps linking from here to
/preferences/commercial-unsubscribe#preference-evaluation-rules
is enough