Skip to content

feat: add ability to override slack scopes #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

cjbell
Copy link
Contributor

@cjbell cjbell commented May 5, 2025

Changed useSlackAuth to:

  • add new options param
  • introduce ability to override scopes
  • change api to break out additionalScopes under options

Copy link

linear bot commented May 5, 2025

Copy link

changeset-bot bot commented May 5, 2025

🦋 Changeset detected

Latest commit: 59e4c6f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@knocklabs/react-core Patch
@knocklabs/react Patch
@knocklabs/expo Patch
@knocklabs/react-native Patch
guide-example Patch
nextjs-example Patch
@knocklabs/expo-example Patch
@knocklabs/react-native-example Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
javascript-ms-teams-connect-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2025 9:48pm
javascript-nextjs-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2025 9:48pm
javascript-slack-connect-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2025 9:48pm
javascript-slack-kit-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2025 9:48pm

Copy link
Contributor

@JEverhart383 JEverhart383 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjbell cjbell force-pushed the cjbell-kno-8591-js-allow-scopes-to-be-overidden-for-slack-useslackauth-hook branch from 7401462 to 59e4c6f Compare May 9, 2025 21:44
@cjbell cjbell merged commit 337bade into main May 9, 2025
7 checks passed
@cjbell cjbell deleted the cjbell-kno-8591-js-allow-scopes-to-be-overidden-for-slack-useslackauth-hook branch May 9, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants