Skip to content

feat(KNO-9338): add branch configuration options #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mattmikolay
Copy link
Contributor

@mattmikolay mattmikolay commented Aug 6, 2025

Description

This PR updates our client SDK and React SDK to support specifying a branch.

Checklist

  • Tests have been added for new features or major refactors to existing features.

Screenshots or videos

** Attach any screenshots or recordings to visually illustrate the changes, as necessary. Delete if not relevant. **

Copy link

linear bot commented Aug 6, 2025

Copy link

changeset-bot bot commented Aug 6, 2025

🦋 Changeset detected

Latest commit: ff7f174

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@knocklabs/react-core Patch
@knocklabs/client Patch
@knocklabs/expo Patch
@knocklabs/react-native Patch
@knocklabs/react Patch
client-example Patch
guide-example Patch
@knocklabs/expo-example Patch
ms-teams-connect-example Patch
nextjs-app-dir-example Patch
nextjs-example Patch
slack-connect-example Patch
slack-kit-example Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@mattmikolay mattmikolay changed the title feat(KNO-9338): add branch option to ApiClient and Knock feat(KNO-9338): add branch configuration option Aug 6, 2025
@mattmikolay mattmikolay changed the title feat(KNO-9338): add branch configuration option feat(KNO-9338): add branch configuration options Aug 6, 2025
Copy link

vercel bot commented Aug 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
javascript-ms-teams-connect-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2025 2:47pm
javascript-nextjs-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2025 2:47pm
javascript-slack-connect-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2025 2:47pm
javascript-slack-kit-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2025 2:47pm

Copy link

codecov bot commented Aug 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.34%. Comparing base (83fb9f0) to head (ff7f174).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #696      +/-   ##
==========================================
+ Coverage   63.29%   63.34%   +0.05%     
==========================================
  Files         181      181              
  Lines        7211     7221      +10     
  Branches      851      851              
==========================================
+ Hits         4564     4574      +10     
  Misses       2621     2621              
  Partials       26       26              
Files with missing lines Coverage Δ
packages/client/src/api.ts 100.00% <100.00%> (ø)
packages/client/src/knock.ts 100.00% <100.00%> (ø)
...ct-core/src/modules/core/context/KnockProvider.tsx 95.55% <100.00%> (+0.20%) ⬆️
.../modules/core/hooks/useAuthenticatedKnockClient.ts 100.00% <100.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant