chore: limit retries for guide client subscribe #697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 98fad19 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
thomaswhyyou
changed the title
thomaswhyyou
commented
Aug 7, 2025
| @@ -263,7 +263,11 @@ describe("KnockGuideClient", () => { | |||
| test("subscribes to socket events when socket is available", () => { | |||
| const mockChannel = { | |||
| join: vi.fn().mockReturnValue({ | |||
| receive: vi.fn().mockReturnValue({ receive: vi.fn() }), | |||
| receive: vi.fn().mockReturnValue({ | |||
There was a problem hiding this comment.
Relied heavily on Claude for writing these tests.
connorlindsey
approved these changes
Aug 7, 2025
thomaswhyyou
force-pushed
the
thomas-kno-8907-sdk-put-a-limit-to-retries-for-channel-subscribe
branch
from
dd5b042 to
1293469
Compare
thomaswhyyou
force-pushed
the
thomas-kno-8907-sdk-put-a-limit-to-retries-for-channel-subscribe
branch
from
1293469 to
90bbb7e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #697 +/- ##
==========================================
+ Coverage 63.35% 63.46% +0.10%
==========================================
Files 181 181
Lines 7220 7247 +27
Branches 853 859 +6
==========================================
+ Hits 4574 4599 +25
- Misses 2620 2622 +2
Partials 26 26
|
thomaswhyyou
deleted the
thomas-kno-8907-sdk-put-a-limit-to-retries-for-channel-subscribe
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the guide client keep retrying forever if it fails to join a guides channel for real time subscription. This can be due to network errors, but also includes auth errors or invalid channel ids. This PR sets a max retry limit at 3, similar to what we do in the main knock client.
References:
https://elixirforum.com/t/how-to-prevent-phoenix-from-retrying-to-connect-to-channel-when-auth-fails/63048
Linear:
KNO-8907