Parse RSA header tag for signature info#58
Merged
Conversation
This was referenced May 12, 2025
Contributor
Author
|
One question I have about this is the ability to get the raw header out (instead of the summarized |
1 task
Owner
It sounds like a good idea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today there is PGP processing that reads
RPMTAG_PGPand populates thePGPfield, however theRPMTAG_RSAHEADERis ignored. Moving forward we should expect to see thePGPtag really only being used for legacy cases while the newerRSAHEADERtag to be used more reliably. This PR does not remove the old field or processing but instead adds thePackageInfo.RSAHeaderfield and applies the same PGP parsing logic that is there today. The only other alteration done was to key PGP v4 vs older shapes based off of a version range check instead of a hardcoded value (otherwise newer versions as used in rockylinux 9 will default to the older pgp data shape).