[Fix] SortedSet#include? returns false #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the Set gem, `@hash = Hash.new(false)`, for the SortedSet it's initialized with a `RBTree` with no default value, which causes the include method to return `nil` when the key is not present. Fixing it and adding a couple of specs.
This was referenced Nov 19, 2021
Author
|
@knu any thoughts on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the Set gem,
@hash = Hash.new(false), for the SortedSet it'sinitialized with a
RBTreewith no default value, which causesthe include method to return
nilwhen the key is not present.Fixing it and adding a couple of specs.