Skip to content

update labelsNode to match new labels interface in kube 1.34 - #1545

Closed
ecordell wants to merge 1 commit into
ko-build:mainfrom
ecordell:kube-1.34-compat
Closed

update labelsNode to match new labels interface in kube 1.34#1545
ecordell wants to merge 1 commit into
ko-build:mainfrom
ecordell:kube-1.34-compat

Conversation

@ecordell

@ecordell ecordell commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

Ran into this when pulling ko in as a library:

# github.com/google/ko/pkg/resolve
pkg/resolve/selector.go:107:26: cannot use labelsNode{…} (value of struct type labelsNode) as labels.Labels value in argument to selector.Matches: labelsNode does not implement labels.Labels (missing method Lookup)
pkg/resolve/selector.go:149:23: cannot use labelsNode{} (value of struct type labelsNode) as labels.Labels value in variable declaration: labelsNode does not implement labels.Labels (missing method Lookup)

I updated the labelsNode implementation to match the new interface. I didn't update the apimachinery dependency in this PR; I'm assuming that ko prefers to track released versions only. This should mean that when it's time to update, there are no conflicts.

@github-actions

github-actions Bot commented Nov 4, 2025

Copy link
Copy Markdown

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

@ecordell

ecordell commented Dec 4, 2025

Copy link
Copy Markdown
Contributor Author

Hey I'd love to re-open and get this going?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant