Skip to content
This repository was archived by the owner on Jul 1, 2024. It is now read-only.

🔧 series floorprice#162

Merged
vikiival merged 3 commits intokodadot:release-004from
roiLeo:fix/series/floorprice
Mar 9, 2023
Merged

🔧 series floorprice#162
vikiival merged 3 commits intokodadot:release-004from
roiLeo:fix/series/floorprice

Conversation

@roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Mar 7, 2023

Beta test on snek

@vikiival vikiival merged commit cfca5ea into kodadot:release-004 Mar 9, 2023
@roiLeo
Copy link
Contributor Author

roiLeo commented Mar 9, 2023

Hmmm... not perfect yet

Screenshot 2023-03-09 at 13-27-56 KodaDot - NFT Market Explorer
Screenshot 2023-03-09 at 13-28-15 test123 KodaDot - NFT Market Explorer

@vikiival
Copy link
Member

vikiival commented Mar 9, 2023

ahah that's why we have test Env ;)

@roiLeo
Copy link
Contributor Author

roiLeo commented Mar 9, 2023

ref #116

Capture d’écran 2023-03-09 à 5 09 52 PM

Tested it locally and I don't have the same result as 004
Are you sure the deploy has been made?

Now issue is, floor_price will be based on all time interaction.
Let's say I:

  • List nft for 10$
  • Relist for 20$
  • floor_price will be 10$ since it's based on all BUY/LIST events

We should base it on last made event. (and we still check burned nft ☹️)
We have to make a nested request.

@roiLeo roiLeo mentioned this pull request Mar 22, 2023
9 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants