Change AllowBackup from Manifest #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
yes this is a good idea, please merge it @kofigyan |
Contributor
Author
|
Ye, sorry about *iml and .idea files ^_^ |
|
There is no need for an application tag in the manifest, could be better to simply delete it, what do you think? |
Owner
|
Thank you @pacdouglas , @connyduck and @ligol and sorry about the delay in response. I am currently looking at this PR and will merge soon. |
|
Merging the #3 PR will fix this issue by the way |
Owner
|
Is merged now. Thanks once again @pacdouglas , @connyduck and @ligol . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm in a project that goes through a security and vunerability tool which one of the requirements is the flag "AllowBackup" of the manifest file to have the value "false". I forked your project and changed that flag. Thanks a lot! I'm also making this "Pull Request" in case you find it interesting and want to make it default so people don't have this problem again.