This repository was archived by the owner on Dec 19, 2025. It is now read-only.
complex type restore #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ENH: add suppport for Kokkos::complex Views * ENH: register Kokkos::complex as a numpy dtype * ENH: bind remaining arithmetic operators for complex numbers * ENH: read dtype properly for complex dtypes * ENH: properly format views with complex data types * ENH: fix issue with getting Kokkos::complex offsets when CUDA is enabled * FIX: add back if condition checking for float64 (removed by accident) * complex: fix comples type tests and conversion * fix atomics * formatting * fix atomics comparison * c++ formatting * version: update kokkos version in the comment --------- Co-authored-by: JBludau <[email protected]> Co-authored-by: Ivan Grigorik <[email protected]>
Collaborator
Author
|
@JBludau can we merge it ASAP since we need to check kokkos/pykokkos#293 Need to be merged before #79 |
Collaborator
Author
|
@gliga, maybe you will check it a bit faster |
gliga
approved these changes
Nov 16, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the revert, the complex types were reverted as well.
This PR just add them again