ENH: greater() to API standard #151
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adjust the `greater()` ufunc to pass its array API standard test, and turn this test on in the CI * this largely mirrors the changes in kokkosgh-150, except that we already had a draft implementation of `greater()` in place here
tylerjereddy
added
enhancement
tylerjereddy
commented
Jan 9, 2023
| def greater_impl_5d_int8(tid: int, | ||
| view1: pk.View5D[pk.int8], | ||
| view2: pk.View5D[pk.int8], | ||
| out: pk.View5D[pk.uint8]): |
Contributor
Author
There was a problem hiding this comment.
usual comments about helping out with formatting apply -- feel free to push in here for all the copy-pasting we need to do b/c we don't have a templating lang
* `test_multi_array_1d_exposed_ufuncs_vs_numpy()` no longer requires specific names for the view kwargs because this was causing issues with how I renamed the view arguments in the `greater()` ufunc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adjust the
greater()ufunc to pass its array API standard test, and turn this test on in the CIthis largely mirrors the changes in ENH: add less ufunc #150, except that we already had a draft implementation of
greater()in place here