ENH: positive() to API std #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* bring `positive()` ufunc up to API standard and turn its test on in the CI; since `positive()` essentially returns a copy view, this can be done fairly simply it seems, though I do wonder if we need to do it differently on GPU (conversely, view assignment in Python should probably just happen naturally depending on default execution space, though I kind of doubt it at the moment) * also required shims to `__eq__` for `Subview`, basically copying the implementation used for regular `View` * an adjustment to `equal()` ufunc was needed to correctly handle two size-0 views it seems * I had to add `test_isnan` and `test_equal` to the CI API standard testing as well because of kokkos#174 (comment) (I'm modifying those ufuncs here and need to make sure their tests still pass...) * I needed to make some weird change to `_typematch_views` -- if you find a way to avoid that, by all means push it in
tylerjereddy
added
enhancement
NaderAlAwar
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bring
positive()ufunc up to API standard and turn its test on in the CI; sincepositive()essentially returns a copy view, this can be done fairly simply it seems, though I do wonder if we need to do it differently on GPU (conversely, view assignment in Python should probably just happen naturally depending on default execution space, though I kind of doubt it at the moment)also required shims to
__eq__forSubview, basically copying the implementation used for regularViewan adjustment to
equal()ufunc was needed to correctly handle two size-0 views it seemsI had to add
test_isnanandtest_equalto the CI API standard testing as well because ofENH: add full_like #174 (comment) (I'm modifying those ufuncs here and need to make sure their tests still pass...)
I needed to make some weird change to
_typematch_views-- if you find a way to avoid that, by all means push it in