Add support for passing pytorch tensors directly to kernel calls #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Contributor
|
If |
Contributor
Author
|
Not at the moment but this is not restricted to PyTorch. We need to have better error messages for invalid arguments passed to kernels. |
JBludau
requested changes
Nov 18, 2025
Contributor
JBludau
left a comment
JBludau
left a comment
There was a problem hiding this comment.
the doctoring is wrong after the change
IvanGrigorik
requested review from
JBludau and
gliga
and removed request for
JBludau and
gliga
gliga
reviewed
Nov 18, 2025
Collaborator
|
All good now, can't merge before @JBludau approval |
JBludau
reviewed
Nov 20, 2025
JBludau
approved these changes
Nov 20, 2025
Contributor
JBludau
left a comment
JBludau
left a comment
There was a problem hiding this comment.
looks good other than the file ending
Contributor
|
As discussed in another PR, can we please add CI check for all line endings |
Collaborator
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checks if torch is installed and uses
torch.is_tensor()to check if the passed argument is a pytorch tensor.