Fix nightly build against Kokkos development CI #302
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The nightly workflow was previously run against the development branch, which is no longer in use
Updated installation command for cmake to require version 3.16 or higher and removed unnecessary CMake policy version setting.
Added commands to check CMake installation and version.
Collaborator
Author
|
My CI test are failing due to pykokkos-base using an old pybind11. I was able to fix the issue and I have a pykokkos-base PR open , so once that is merged my CI tests should pass. |
Collaborator
Author
|
This will also close #303 |
Removed Python version 3.14 from CI workflow and updated installation command.
Contributor
|
https://github.com/kokkos/pykokkos/actions/runs/18383417161/job/52375654916?pr=302 indicates you are missing a package to do the type checking stage
But the CI does not fail while installing pykokkos-base. Nevertheless, I think updating the pinned version of pybind11 is a good thing |
Contributor
|
Closing. Addressed in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.