Skip to content

doc: add status badges #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
IvanGrigorik merged 4 commits into from
Nov 9, 2025
Merged

doc: add status badges #309

IvanGrigorik merged 4 commits into from
Nov 9, 2025

Conversation

@IvanGrigorik
Copy link
Collaborator

@IvanGrigorik IvanGrigorik commented Nov 8, 2025

Add status badges for pykokkos-base linux CI and pykokkos tests

@IvanGrigorik
doc: add CI badges to README
31615a7 
Added CI badges for Python and Array API testing.
@IvanGrigorik
doc: add CI badges for linux and python package
a6fde8f 
Added CI badges for linux and python package workflows.
@IvanGrigorik IvanGrigorik requested review from JBludau and gliga November 8, 2025 15:02
@gliga
Copy link
Contributor

gliga commented Nov 8, 2025

Why are we adding badges for pykokkos-base in this repo?

@JBludau
Copy link
Contributor

JBludau commented Nov 8, 2025

Why are we adding badges for pykokkos-base in this repo?

I agree, we should add them in pykokkos-base. Otherwise this could give a wrong impression

@IvanGrigorik
Copy link
Collaborator Author

IvanGrigorik commented Nov 9, 2025

I thought we have a plan of merging pykokkos-base into pykokkos repo
Sure i can add them separately

@gliga
Copy link
Contributor

gliga commented Nov 9, 2025

Our plan is to merge the two repositories, but I do not see how providing badges is going to help.
If we want to merge now, then we should

  • Move pykokkos-base under base directory in this repo
  • Archive pykokkos-base
  • Enable CI runs for the base directory
  • Include badges in this repo for the CI runs for this repo

@IvanGrigorik
doc: update README to remove CI badges from pykokkos-base
8703463 
Removed unnecessary CI badges from README.
@IvanGrigorik
Copy link
Collaborator Author

IvanGrigorik commented Nov 9, 2025

Removed. I cancelled workflows since the PR does not change anything in codebase except readme

@gliga
Copy link
Contributor

gliga commented Nov 9, 2025

No need to cancel workflows. They do not directly cost you anything.

gliga
gliga approved these changes Nov 9, 2025
View reviewed changes
Copy link
Contributor

@gliga gliga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about badge for the documentation we have?

@IvanGrigorik
Copy link
Collaborator Author

IvanGrigorik commented Nov 9, 2025

How about badge for the documentation we have?

Sure. Done

@IvanGrigorik
Copy link
Collaborator Author

IvanGrigorik commented Nov 9, 2025

I also added badges for pykokkos-base:
kokkos/pykokkos-base#74

@IvanGrigorik IvanGrigorik merged commit e424142 into main Nov 9, 2025
5 checks passed
@IvanGrigorik IvanGrigorik deleted the grigorik/status-badge branch November 16, 2025 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gliga gliga gliga approved these changes

@JBludau JBludau Awaiting requested review from JBludau

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@IvanGrigorik @gliga @JBludau