core: scratch size getting for multiple types and dimensions #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanGrigorik
force-pushed
the
grigorik/scratch_size_support
branch
from
0bdce6a to
411d4f7
Compare
gliga
reviewed
Dec 25, 2025
| return int(self.data[0]) | ||
|
|
Contributor
There was a problem hiding this comment.
why are we formatting code?
Can we please check formatting of all files in our CI.
Collaborator
Author
There was a problem hiding this comment.
We have a bit problem with file formatting in PyKokkos
I will open another PR in which I will format all pykokkos file in a single black stype
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added unit tests and implementation of
ScratchView?D(where?is dimension from 1 to 8 andshmem_sizeto get shared memory size for any dimension and for any type