Skip to content

Conversation

@kennykos
Copy link
Collaborator

@kennykos kennykos commented Jan 2, 2026

Closes #234

@kennykos kennykos changed the title Recompile output if outdated Recompile pk_cpp if outdated Jan 2, 2026
@IvanGrigorik IvanGrigorik self-requested a review January 2, 2026 22:26
@IvanGrigorik
Copy link
Collaborator

@kennykos can you add some unit test to verify the correctness?

@gliga
Copy link
Contributor

gliga commented Jan 2, 2026

We should not use timestamps to check if something is new(er). We should use hashes of files/directories.

@kennykos
Copy link
Collaborator Author

kennykos commented Jan 3, 2026

We should not use timestamps to check if something is new(er). We should use hashes of files/directories.

The most recent commit checks the compiled functor.hpp file directly.

@kennykos
Copy link
Collaborator Author

kennykos commented Jan 3, 2026

@kennykos can you add some unit test to verify the correctness?

I'm not sure how to write unit tests for this without using exec as it involves files being changed. Do you have any ideas?

@IvanGrigorik
Copy link
Collaborator

@kennykos can you add some unit test to verify the correctness?

I'm not sure how to write unit tests for this without using exec as it involves files being changed. Do you have any ideas?

It would be enough to test is_current directly, not whole app.
But if you want to check the whole app - you can append one char of file during tests and do 3 exec rounds in a loop or something like that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pk_cpp is not removed if kernel changes which keeps reporting an error

4 participants