-
Notifications
You must be signed in to change notification settings - Fork 21
examples: view deprecation #341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
13e451c to
ccf8174
Compare
|
Since examples does not have unit tests I will post before/after change results in the comment section. |
|
ExaMiniMD (success): Click to expand
|
|
BabelStream (workload and functor still fails, need to modify Click to expand
after change: Function MBytes/sec Min (sec) Max Average before change: Function MBytes/sec Min (sec) Max Average |
|
Details
$ pip install sklearn
Collecting sklearn
Using cached sklearn-0.0.post12.tar.gz (2.6 kB)
Installing build dependencies ... done
Getting requirements to build wheel ... error
error: subprocess-exited-with-error
× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> [15 lines of output]
The 'sklearn' PyPI package is deprecated, use 'scikit-learn'
rather than 'sklearn' for pip commands.
Here is how to fix this error in the main use cases:
- use 'pip install scikit-learn' rather than 'pip install sklearn'
- replace 'sklearn' by 'scikit-learn' in your pip requirements files
(requirements.txt, setup.py, setup.cfg, Pipfile, etc ...)
- if the 'sklearn' package is used by one of your dependencies,
it would be great if you take some time to track which package uses
'sklearn' instead of 'scikit-learn' and report it to their issue tracker
- as a last resort, set the environment variable
SKLEARN_ALLOW_DEPRECATED_SKLEARN_PACKAGE_INSTALL=True to avoid this error
More information is available at
https://github.com/scikit-learn/sklearn-pypi-package
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
ERROR: Failed to build 'sklearn' when getting requirements to build wheel
When trying to install scikit-learn there will be some problems with the code itself. |
|
Everything in |
Nothing is running on GPU? We do not need to update examples that use workload style. |
It works good on GPU. For example, pykokkos/examples/pykokkos/from_array.py Lines 12 to 15 in 18b5e59
These example runs on GPU and works fine. It's just that most examples using numpy and OpenMP |
This PR removes all views from examples #333
All views are changed into cupy / numpy arrays