Skip to content

add insertTextAtCursor #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add insertTextAtCursor #337

wants to merge 3 commits into from

Conversation

dotknyl
Copy link

@dotknyl dotknyl commented Jan 14, 2021

insertTextAtCursor by click a button outside of editor

ISSUE: (Can see on angular-editor-app) it can insert to the first editor but cannot insert to the second
i selected the 2nd editor, but it still insert the the 1st editor

HOPE you add this method, by Accept the pull request or Add new method. I saw many issue need this method.

@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #337 (6b8cfd2) into master (039551a) will decrease coverage by 0.13%.
The diff coverage is 11.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #337      +/-   ##
==========================================
- Coverage   18.81%   18.68%   -0.14%     
==========================================
  Files           7        7              
  Lines         473      487      +14     
  Branches      103      106       +3     
==========================================
+ Hits           89       91       +2     
- Misses        372      384      +12     
  Partials       12       12              
Impacted Files Coverage Δ
...s/angular-editor/src/lib/angular-editor.service.ts 2.80% <3.03%> (-0.94%) ⬇️
...angular-editor/src/lib/angular-editor.component.ts 14.52% <15.18%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 039551a...6b8cfd2. Read the comment docs.

@kolkov
Copy link
Owner

kolkov commented Jan 23, 2021

Thanks for the PR! I check it soon as possible.

@Pavan90
Copy link

Pavan90 commented Mar 29, 2021

any progress on this PR ? @dotknyl I am not able to insert Text on first editor either. Am I missing something ?

I tried here: https://angular-editor.kolkov.ru/

@dotknyl
Copy link
Author

dotknyl commented Apr 1, 2021

any progress on this PR ? @dotknyl I am not able to insert Text on first editor either. Am I missing something ?

I tried here: https://angular-editor.kolkov.ru/

I tried to use this feature for my project. It's working but got issues in some cases.
It's have this problem because I don't really understand enough about Selection.
You or anyone else can help me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants