Refactor: replace APIReader with cache configuration for memory optimization #428
+101
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
qixiang
changed the title
Contributor
Author
|
This change needs to be validated in a cluster with a large number of components to properly verify whether it works. I plan to merge and deploy it after the new year and verify it in the p02 cluster. |
qixiang
force-pushed
the
disable-cache
branch
2 times, most recently
from
a4aa680 to
df74e4f
Compare
…ization The previous implementation (58c7dbe) used APIReader to bypass the cache for infrequently accessed resources. This commit replaces that approach with controller-runtime's built-in cache configuration options. For non-watched resources use DisableFor to prevent lazy informer creation when Client.Get/List is called. Without this, a single Get/List call would create a cluster-wide informer that caches ALL objects of that type. For watched resources (DependencyUpdateCheck, Event, PipelineRun), use namespace-scoped caching to limit informers to the mintmaker namespace only. Also apply TransformStripManagedFields to reduce cached object size.
staticf0x
reviewed
Jan 7, 2026
staticf0x
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation (58c7dbe) used APIReader to bypass the cache for infrequently accessed resources. This commit replaces that approach with controller-runtime's built-in cache configuration options.
For non-watched resources use DisableFor to prevent lazy informer creation when Client.Get/List is called. Without this, a single Get/List call would create a cluster-wide informer that caches ALL objects of that type.
For watched resources (DependencyUpdateCheck, Event, PipelineRun), use namespace-scoped caching to limit informers to the mintmaker namespace only. Also apply TransformStripManagedFields to reduce cached object size.