refactor: patching ContainerImage to add repositories #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a followup of what was done in konflux-ci#303 Most notably: - rename the image_already_exists to find_image to reflect what it does - it used to return bool, now it returns the image if found. - only include the repositories field in the patch payload - for consistency, create the same two repo entries when adding a new repository like we do when creating a brand new image Signed-off-by: Martin Malina <[email protected]>
mmalina
force-pushed
the
patch-repository
branch
from
3ce907f
to
c5315ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup of what was done in #303
Most notably: