-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(RELEASE-1214): add support for spdx sbom format #307
Conversation
87095a9
to
7249247
Compare
So for the review, upload_rpm_data_cyclonedx.py and test_upload_rpm_data_cyclonedx.py are just copies and do not need review? |
Correct.
Yeah, for now we will run one of the scripts depending on the sbom type: https://github.com/konflux-ci/release-service-catalog/pull/685/files And eventually we will remove the upload_rpm_data_cyclonedx.py script and the logic in the task and support just spdx. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm otherwise
f67c7d5
to
5f39100
Compare
Build team is moving from cyclonedx to spdx sbom format. To support both formats until the transition is over: * The original upload_rpm_data was copied as upload_rpm_data_cyclonedx to preserve the original behavior for now * upload_rpm_data was modified to work with spdx format Signed-off-by: Martin Malina <[email protected]>
5f39100
to
55f2029
Compare
Build team is moving from cyclonedx to spdx sbom format. To support both formats until the transition is over: