fix: update slack-go/slack to v0.17.3 to fix JSON unmarshal error #134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
slack-go/slackfrom v0.17.1 to v0.17.3Problem
When Slack API returns errors as strings instead of objects, the library fails with:
This happens because
SlackResponseErrors.UnmarshalJSONin v0.17.1 doesn't handle string error values:Root Cause
This is a known bug in slack-go/slack, tracked and fixed upstream:
Fix
Simply update the dependency to v0.17.3 which includes the fallback for string errors:
Test plan
TestSlackErrorStringUnmarshalto verify string errors are handledTestSlackErrorObjectUnmarshalto verify object errors still workgo test ./...