feat: port generate-folders function from TS to Go by danish9039 · Pull Request #1216 · kptdev/krm-functions-catalog

danish9039 · 2026-02-16T12:38:59Z

This PR ports the generate-folders KRM function from TypeScript to Go, adding it to the functions/go directory.
solves

Port generate-folders KRM fn to golang kpt#4295

Changes

Implemented core logic in transformer/generate_folders.go
Added unit tests in transformer/generate_folders_test.go covering:
- API version handling (v1alpha3, v1, v2)
- Parent reference handling (Folder, Organization)
- Annotation inheritance and filtering
- Name normalization
Verified cross-compilation for js,wasm target
Added function to functions/go/Makefile

Verification

Ran make func-verify (passed)
Verified GOOS=js GOARCH=wasm go build (passed)
All 26 unit tests passed

Copilot

Pull request overview

Ports the generate-folders KRM function into the Go functions catalog, implementing ResourceHierarchy→Folder generation (including v3 native refs), wiring up CLI/wasm entrypoints, and adding documentation plus Go-based unit/integration tests.

Changes:

Added Go transformer implementation for v1/v2/v3 ResourceHierarchy processing and Folder manifest generation.
Added Go test suite + YAML fixtures for v2/v3 scenarios (namespace, parent kinds, annotation filtering, normalization, deprecation warning).
Added function packaging/entrypoints (main, run targets) and registered the function in functions/go/Makefile.

Reviewed changes

Copilot reviewed 16 out of 18 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
functions/go/generate-folders/transformer/generate_folders.go	Core Go implementation for parsing ResourceHierarchy and generating Folder resources
functions/go/generate-folders/transformer/generate_folders_test.go	Unit/integration tests for normalization, subtree expansion, and v2/v3 end-to-end behavior
functions/go/generate-folders/transformer/testdata/simple_v3.yaml	v3 basic hierarchy fixture
functions/go/generate-folders/transformer/testdata/v3_with_namespace.yaml	v3 fixture validating namespace + depends-on behavior
functions/go/generate-folders/transformer/testdata/v3_folder_parent.yaml	v3 fixture validating Folder parentRef
functions/go/generate-folders/transformer/testdata/v2_deprecation.yaml	v2 fixture validating deprecation warning + annotation-based refs
functions/go/generate-folders/transformer/testdata/missing_parent_ref.yaml	Fixture validating missing parentRef error result
functions/go/generate-folders/transformer/testdata/annotation_inheritance.yaml	Fixture validating annotation filtering/inheritance behavior
functions/go/generate-folders/main.go	CLI entrypoint
functions/go/generate-folders/run.go	Non-wasm runner wiring the transformer into fn.AsMain
functions/go/generate-folders/run_js.go	wasm/js runner wiring (processResourceList / processResourceListErrors)
functions/go/generate-folders/README.md	Function documentation and examples
functions/go/generate-folders/metadata.yaml	Function metadata (image, tags, sourceURL, license)
functions/go/generate-folders/generated/docs.go	Generated placeholder package for docs tooling
functions/go/generate-folders/go.mod	New Go module definition for the function
functions/go/generate-folders/go.sum	Dependency lockfile for the module
functions/go/Makefile	Registers `generate-folders` in the Go functions build/verify targets

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

functions/go/generate-folders/transformer/generate_folders.go

functions/go/generate-folders/README.md

functions/go/generate-folders/transformer/generate_folders_test.go

mozesl-nokia · 2026-02-16T15:58:08Z

functions/go/generate-folders/go.mod

@@ -0,0 +1,35 @@
+module github.com/kptdev/krm-functions-catalog/functions/go/generate-folders
+
+go 1.25.6


You should probably bump the go version to 1.25.7 as I assume we will be updating the other functions shortly as well.

Bumped the module to Go 1.25.7.

mozesl-nokia · 2026-02-16T16:00:09Z

functions/go/generate-folders/metadata.yaml

+sourceURL: https://github.com/kptdev/krm-functions-catalog/tree/main/functions/go/generate-folders
+
+emails:
+  - kpt-team@google.com


Pretty sure this email is no longer relevant, but I'm not sure we have any relevant mailing lists... (this applies to the rest of the functions too)

I would suggest just removing the emails field altogether for now.

Removed the emails field for now.

mozesl-nokia · 2026-02-20T12:05:44Z

functions/go/generate-folders/run.go

+package main
+
+import (
+	transformer "github.com/kptdev/krm-functions-catalog/functions/go/generate-folders/transformer"


Unnecessary alias

Cleaned this up. The explicit alias is gone and the file now uses the package name directly.

mozesl-nokia · 2026-02-20T12:05:53Z

functions/go/generate-folders/run_js.go

+import (
+	"syscall/js"
+
+	transformer "github.com/kptdev/krm-functions-catalog/functions/go/generate-folders/transformer"


Unnecessary alias

Same here. Removed the extra alias and used the package name directly.

mozesl-nokia · 2026-02-20T12:08:42Z

functions/go/generate-folders/README.md

+## Function Invocation
+
+```shell
+kpt fn eval --image ghcr.io/kptdev/krm-functions-catalog/generate-folders:unstable


The tag here should not be "unstable", either "latest" or whatever will be the actual tag once released (v0.1.0?)

Updated the README example to use latest instead of unstable.

mozesl-nokia · 2026-02-20T12:18:39Z

functions/go/generate-folders/transformer/generate_folders.go

+
+	root := &hierarchyNode{
+		name: orgID,
+		kind: "Organization",


"Organization" should be a const

Fixed this one too. Organization is now consistently referenced through a constant.

mozesl-nokia · 2026-02-20T12:20:52Z

functions/go/generate-folders/transformer/generate_folders.go

Could you split this file up somehow? It is a bit long...

One chunk could definitely be the normalization related things (regexes, the functions themselves).

I left the file split out of this PR. I wanted to keep the review scope on the behavioral fixes first. I can do the normalization split as a follow-up cleanup.

mozesl-nokia · 2026-02-20T12:23:44Z

functions/go/generate-folders/transformer/generate_folders.go

+
+// filterNonInheritableAnnotations removes non-inheritable annotations.
+func filterNonInheritableAnnotations(annotations map[string]string) map[string]string {
+	if annotations == nil {


Suggested change

if annotations == nil {

if len(annotations) == 0 {

mozesl-nokia · 2026-02-20T12:24:49Z

functions/go/generate-folders/transformer/generate_folders_test.go

Please use testify's assert and require packages instead of t.Errorf and t.Fatalf.

Updated the tests to use testify assert and require.

mozesl-nokia · 2026-02-20T12:40:17Z

functions/go/generate-folders/transformer/generate_folders_test.go

+	return data
+}
+
+// Integration tests using full YAML ResourceList inputs


Would these bigger tests not be better placed in the E2E tests?

I moved the larger fixture-driven checks into repo E2E cases under tests/generate-folders and kept the transformer test file focused on unit-level behavior.

netlify · 2026-02-28T21:11:05Z

❌ Deploy Preview for krm-function-catalog failed. Why did it fail? →

Name	Link
🔨 Latest commit	`42e1211`
🔍 Latest deploy log	https://app.netlify.com/projects/krm-function-catalog/deploys/69b558f63b70ab0008ee8905

danish9039 · 2026-03-01T16:42:36Z

@mozesl-nokia PTAL

CsatariGergely · 2026-03-11T13:46:49Z

@danish9039 please address the DCO issue: https://github.com/kptdev/krm-functions-catalog/pull/1216/checks?check_run_id=65266203488

Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>

- fix(v1): thread path for proper nested folder naming - fix(compat): remove subtree sorting to match TS implementation - fix(errors): improve error messages for subtree processing - docs: clarify v1 annotation inheritance limitation - test: add v1 integration test with nested hierarchy Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>

Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>

danish9039 · 2026-03-14T07:36:09Z

Rewrote the branch history with sign-offs on all PR commits and force-pushed the branch. The DCO check is passing on the current head (01d6282).

Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>

Copilot AI review requested due to automatic review settings February 16, 2026 12:39

danish9039 requested review from efiacor, kispaljr, liamfallon and mozesl-nokia as code owners February 16, 2026 12:39

Copilot started reviewing on behalf of danish9039 February 16, 2026 12:39 View session

Copilot AI reviewed Feb 16, 2026

View reviewed changes

mozesl-nokia requested changes Feb 20, 2026

View reviewed changes

danish9039 force-pushed the issue-4295/port-generate-folders branch from b2c4b46 to a60d169 Compare February 28, 2026 21:22

danish9039 added 4 commits March 14, 2026 13:05

feat: port generate-folders function from TS to Go

d796e6a

Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>

fix generate-folders review feedback

196cfb6

Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>

polish generate-folders review nits

01d6282

Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>

danish9039 force-pushed the issue-4295/port-generate-folders branch from a60d169 to 01d6282 Compare March 14, 2026 07:35

fix: make generate-folders e2e idempotent

42e1211

Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>

		@@ -0,0 +1,35 @@
		module github.com/kptdev/krm-functions-catalog/functions/go/generate-folders

		go 1.25.6

Conversation

danish9039 commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Verification

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

netlify bot commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Deploy Preview for krm-function-catalog failed. Why did it fail? →

Uh oh!

danish9039 commented Mar 1, 2026

Uh oh!

CsatariGergely commented Mar 11, 2026

Uh oh!

danish9039 commented Mar 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

danish9039 commented Feb 16, 2026 •

edited

Loading

netlify bot commented Feb 28, 2026 •

edited

Loading