Open menu items in same tab and remove installation menu point#1219
Merged
CsatariGergely merged 10 commits intokptdev:mainfrom Mar 11, 2026
Merged
Open menu items in same tab and remove installation menu point#1219CsatariGergely merged 10 commits intokptdev:mainfrom
CsatariGergely merged 10 commits intokptdev:mainfrom
Conversation
Fixing a Hugo vs Docsy incompatibility error. Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
CsatariGergely
requested review from
efiacor,
kispaljr,
liamfallon and
mozesl-nokia
as code owners
There was a problem hiding this comment.
Pull request overview
This PR modifies the documentation site to open menu navigation links in the same browser tab instead of opening external links in new tabs. The changes include removing the target="_blank" attribute from navbar links, improving null-safety in Hugo templates by replacing isset checks with and patterns, and reorganizing the main menu structure.
Changes:
- Removed conditional
target="_blank"from navbar links so all menu items open in the same tab - Enhanced null-safety in sidebar template by replacing
issetwithandchecks and adding defensive fallback logic - Removed "Installation" menu item and adjusted menu weights to maintain sequential ordering
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| documentation/layouts/partials/navbar.html | Removes target="_blank" attribute to open all navbar links in same tab |
| documentation/layouts/partials/sidebar-tree.html | Replaces isset with and pattern for null-safe property access and adds defensive variable extraction |
| documentation/config.toml | Removes "Installation" menu item and reorders menu weights |
| documentation/content/en/_index.md | Adjusts main menu weight from 40 to 30 |
| documentation/go.mod | Adds docsy theme as indirect dependency |
| documentation/Makefile | Fixes missing trailing backslash for command continuation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
CsatariGergely
changed the title
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
✅ Deploy Preview for krm-function-catalog ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Due ot a bug in Netlify it ignored the HUGO_VERSION directive in the config file what makes the deployment fail. Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Netlify build environment seems to require the explicit definition of a set of Docsy parameters. Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
CsatariGergely
changed the title
liamfallon
approved these changes
Feb 26, 2026
mozesl-nokia
approved these changes
Mar 4, 2026
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening back links in the same window
Some housekeeping changes: