Fix create-setters matching setter values in internal kpt annotations

[aravindtga]

Fixes kptdev/kpt#4462

Summary

The create-setters function was incorrectly creating setter comments on internal.config.kubernetes.io/* and config.kubernetes.io/* annotations. These are kpt runtime metadata injected during fn render (e.g. filesystem paths) and are not user-authored resource content. When a setter value like 4 appeared as a substring in a temp directory path, the function would produce spurious and non-deterministic results.

Changes

functions/go/create-setters/createsetters/create_setters.go:

• Added a path check in visitScalar() to skip fields under internal.config.kubernetes.io and `config.kubernetes.io annotations

functions/go/create-setters/createsetters/create_setters_test.go:

• Added test case skip internal kpt annotations verifying that:
  • internal.config.kubernetes.io/package-path containing the setter value is not matched
  • config.kubernetes.io/local-config` is not matched
  • Regular fields like spec.replicas still correctly receive setter comments

[netlify]

✅ Deploy Preview for krm-function-catalog canceled.

Name	Link
🔨 Latest commit	fe096cc
🔍 Latest deploy log	https://app.netlify.com/projects/krm-function-catalog/deploys/69dca9f8b159a100086eeb29

[aravindtga]

This should be rebased once #1227 is merged.

[Copilot]

Pull request overview

Fixes non-deterministic setter comment generation by preventing create-setters from matching and annotating kpt runtime metadata stored in internal.config.kubernetes.io/* and config.kubernetes.io/* annotations.

Changes:

• Skip scalar nodes whose field path is under metadata.annotations.internal.config.kubernetes.io/* or metadata.annotations.config.kubernetes.io/*.
• Add a regression test ensuring annotation values containing a setter substring are ignored while normal fields (e.g. spec.replicas) still get kpt-set comments.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
functions/go/create-setters/createsetters/create_setters.go	Adds a path-based guard in visitScalar to avoid generating setter comments for internal/config kpt annotations.
functions/go/create-setters/createsetters/create_setters_test.go	Adds a test case validating internal/config kpt annotations are skipped while regular fields continue to be annotated.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.