Skip to content

Move anno-apply-time-mut fn to main track#1241

Merged
efiacor merged 6 commits intokptdev:mainfrom
Nordix:move_anno_applytime_mut_fn
Apr 28, 2026
Merged

Move anno-apply-time-mut fn to main track#1241
efiacor merged 6 commits intokptdev:mainfrom
Nordix:move_anno_applytime_mut_fn

Conversation

@efiacor
Copy link
Copy Markdown
Collaborator

@efiacor efiacor commented Apr 24, 2026

Move anno-apply-time-mutations fn to main track.
Remove contrib build/CI infra

@efiacor efiacor requested a review from CsatariGergely April 24, 2026 12:43
@efiacor efiacor self-assigned this Apr 24, 2026
Copilot AI review requested due to automatic review settings April 24, 2026 12:43
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 24, 2026

Deploy Preview for krm-function-catalog canceled.

Name Link
🔨 Latest commit 92d3a75
🔍 Latest deploy log https://app.netlify.com/projects/krm-function-catalog/deploys/69ef8d5f7f81e70007975459

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Moves the annotate-apply-time-mutations KRM function from contrib/ into the main functions/go/ track and refreshes examples/docs to match the new image/module locations.

Changes:

  • Migrate annotate-apply-time-mutations into functions/go/ with new module metadata, entrypoint, and examples.
  • Update build orchestration to include the function in the main Go functions Makefile and remove the contrib Go Makefile/examples.
  • Adjust import/module paths (e.g., kubeconform) and update generated docs/readme content to reference the new image location.

Reviewed changes

Copilot reviewed 37 out of 42 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
functions/go/kubeconform/main.go Updates generated import path to the non-contrib module location.
functions/go/kubeconform/go.mod Changes module path from contrib/... to functions/....
functions/go/annotate-apply-time-mutations/pkg/types.go Adds ApplyTimeMutation type definitions in the main track.
functions/go/annotate-apply-time-mutations/metadata.yaml Adds main-track function image/metadata.
functions/go/annotate-apply-time-mutations/main.go Adds main entrypoint for the function binary.
functions/go/annotate-apply-time-mutations/go.mod Adds a new Go module for the main-track function.
functions/go/annotate-apply-time-mutations/go.sum Adds dependency lockfile for the new module.
functions/go/Makefile Adds annotate-apply-time-mutations to the main Go functions list.
examples/annotate-apply-time-mutations-inline-comment/resources.yaml Adds new main-track inline-comment example resources.
examples/annotate-apply-time-mutations-inline-comment/README.md Adds new main-track inline-comment example documentation.
examples/annotate-apply-time-mutations-inline-comment/.expected/diff.patch Adds expected output for inline-comment example eval test.
examples/annotate-apply-time-mutations-inline-comment/.expected/config.yaml Adds eval test configuration for inline-comment example.
examples/annotate-apply-time-mutations-custom-resource/resources.yaml Adds new main-track custom-resource example resources.
examples/annotate-apply-time-mutations-custom-resource/README.md Adds new main-track custom-resource example documentation.
examples/annotate-apply-time-mutations-custom-resource/.expected/diff.patch Adds expected output for custom-resource example eval test.
examples/annotate-apply-time-mutations-custom-resource/.expected/config.yaml Adds eval test configuration for custom-resource example.
contrib/functions/go/annotate-apply-time-mutations/pkg/types.go Removes types from contrib location (now defined in main track).
contrib/functions/go/annotate-apply-time-mutations/pkg/object_scanner_test.go Prepends license header in contrib test file.
contrib/functions/go/annotate-apply-time-mutations/pkg/object_scanner.go Prepends license header in contrib source file.
contrib/functions/go/annotate-apply-time-mutations/pkg/function_test.go Prepends license header in contrib test file.
contrib/functions/go/annotate-apply-time-mutations/pkg/function.go Prepends license header in contrib source file.
contrib/functions/go/annotate-apply-time-mutations/pkg/comment_scanner_test.go Prepends license header in contrib test file.
contrib/functions/go/annotate-apply-time-mutations/pkg/comment_scanner.go Adds license header and modernizes interface{} to any.
contrib/functions/go/annotate-apply-time-mutations/pkg/annotation_test.go Prepends license header in contrib test file.
contrib/functions/go/annotate-apply-time-mutations/pkg/annotation.go Prepends license header in contrib source file.
contrib/functions/go/annotate-apply-time-mutations/metadata.yaml Removes contrib metadata.yaml (function moved to main track).
contrib/functions/go/annotate-apply-time-mutations/main.go Removes contrib entrypoint (function moved to main track).
contrib/functions/go/annotate-apply-time-mutations/go.sum Removes contrib module go.sum (module removed).
contrib/functions/go/annotate-apply-time-mutations/go.mod Removes contrib module go.mod (module removed).
contrib/functions/go/annotate-apply-time-mutations/generated/docs.go Updates generated docs content and image references.
contrib/functions/go/annotate-apply-time-mutations/README.md Updates README content and image references.
contrib/functions/go/Makefile Removes contrib Go functions Makefile (build now via main track).
contrib/examples/annotate-apply-time-mutations-inline-comment/resources.yaml Removes contrib inline-comment example resources.
contrib/examples/annotate-apply-time-mutations-inline-comment/README.md Removes contrib inline-comment example README.
contrib/examples/annotate-apply-time-mutations-inline-comment/.expected/diff.patch Removes contrib inline-comment expected patch.
contrib/examples/annotate-apply-time-mutations-inline-comment/.expected/config.yaml Removes contrib inline-comment expected config.
contrib/examples/annotate-apply-time-mutations-custom-resource/resources.yaml Removes contrib custom-resource example resources.
contrib/examples/annotate-apply-time-mutations-custom-resource/README.md Removes contrib custom-resource example README.
contrib/examples/annotate-apply-time-mutations-custom-resource/.expected/diff.patch Removes contrib custom-resource expected patch.
contrib/examples/annotate-apply-time-mutations-custom-resource/.expected/config.yaml Removes contrib custom-resource expected config.
Comments suppressed due to low confidence (3)

functions/go/annotate-apply-time-mutations/pkg/types.go:1

  • Typo in comment: replace 'seperate' with 'separate'.
    functions/go/annotate-apply-time-mutations/pkg/types.go:1
  • The JSON tags for Kubernetes-style API types typically mark metadata and spec (and often nested fields like targetRef) as omitempty to avoid emitting empty objects when marshaling. This file previously used omitempty in the contrib version; restoring that behavior (json:\"metadata,omitempty\", json:\"spec,omitempty\", json:\"targetRef,omitempty\") helps maintain wire-format compatibility and aligns with common Kubernetes conventions.
    functions/go/annotate-apply-time-mutations/pkg/types.go:1
  • The JSON tags for Kubernetes-style API types typically mark metadata and spec (and often nested fields like targetRef) as omitempty to avoid emitting empty objects when marshaling. This file previously used omitempty in the contrib version; restoring that behavior (json:\"metadata,omitempty\", json:\"spec,omitempty\", json:\"targetRef,omitempty\") helps maintain wire-format compatibility and aligns with common Kubernetes conventions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread examples/annotate-apply-time-mutations-inline-comment/resources.yaml Outdated
efiacor added 4 commits April 27, 2026 13:25
Signed-off-by: Fiachra Corcoran <fiachra.corcoran@est.tech>
Signed-off-by: Fiachra Corcoran <fiachra.corcoran@est.tech>
Signed-off-by: Fiachra Corcoran <fiachra.corcoran@est.tech>
Signed-off-by: Fiachra Corcoran <fiachra.corcoran@est.tech>
@efiacor efiacor force-pushed the move_anno_applytime_mut_fn branch from 416c51d to e8ae7e4 Compare April 27, 2026 12:53
efiacor added 2 commits April 27, 2026 13:57
Signed-off-by: Fiachra Corcoran <fiachra.corcoran@est.tech>
Signed-off-by: Fiachra Corcoran <fiachra.corcoran@est.tech>
Comment thread functions/go/annotate-apply-time-mutations/go.mod
@efiacor efiacor merged commit 6a14603 into kptdev:main Apr 28, 2026
12 checks passed
@efiacor efiacor deleted the move_anno_applytime_mut_fn branch April 28, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants