Skip to content

Conversation

@elf-alchemist
Copy link
Contributor

Somewhat experimental change that has consequences for demo recording.

This should completely fix demo recording for Eviternity II, without needing the mapinfo patch -- but also has the major fix of enabling normal demos (non-ExCMdDemo) for DSDA-UDMF/ZDoom maps. Thus allowing valid recording for DSDA-UDMF map sets, like NoSp4, as ExCmdDemos always fail analysis testing, being classified as "Other".

@rfomin
Copy link
Collaborator

rfomin commented Nov 12, 2025

These new demos will not be compatible with other ports or old versions of DSDA-Doom. We will need a new complevel for UDMF/MAPINFO demos.
If we add a new complevel, there is no reason to remove ExCmdDemo; analysis should be updated to support the new complevel.

@elf-alchemist
Copy link
Contributor Author

I would not use the term conplevel, here, but if it just means putting these advanced, ZDoom-originated, features behind a user-provided CLI parameter or the like, I wouldn't object to it. But the current state of demo recording for these kinds of maps is extremely sub-bar for end users, it needs some important revision, and most solutions I can think of are tricky or include some major compromise (I may elaborate further, later). I will update this PR in a bit, I've noticed an issue with how it's currently laid out.

@rfomin
Copy link
Collaborator

rfomin commented Nov 12, 2025

I will update this PR in a bit, I've noticed an issue with how it's currently laid out.

The current approach won't work — these new demos won't be compatible. This defeats the purpose of a demo-compatible port.
We will need to add a new complevel (demo_version), after which we can make any changes or improvements we want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants